From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Alexandr Barulev <huston.mavr@gmail.com>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>,
tarantool-patches@dev.tarantool.org,
Yaroslav Dynnikov <yaroslav.dynnikov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v2] Add missed icu symbols
Date: Mon, 28 Sep 2020 08:26:05 +0200 [thread overview]
Message-ID: <861c8e85-83f0-6640-75bc-7f5d923c4f47@tarantool.org> (raw)
In-Reply-To: <CAL+-_m8UukrWDLSyQ8TLYykv5sCstXG1CU67iZ5Vjm2=Y__NPw@mail.gmail.com>
On 28.09.2020 00:39, Alexandr Barulev wrote:
> Hello, thanks for the review of new patch version!
>
> I've fixed commit message (added `build` prefix) and rebased
> from master.
>
> I think commit, mentionied at patch message ("cmake: remove
> dynamic-list linker option") is related to #5266 issue.
> It's because symbols exports from required libs into tarantool binary
> earlier were configured with two options:
> by `--whole-archive` option;
> and `--dynamic-list,${exports_file}` option, where exports_file was created
> with use of mkexports script (symbols was grabbed by nm -D from shared
> libraries).
>
> Also, I've checkouted "cmake: remove dynamic-list linker option"
> commit, built static tarantool and ran icu-date tests. In result
> tests failed with `undefined symbol` errors.
> After that, I checkouted previous commit, built tarantool again
> and icu-date tests succeed
Ok, so this is because of whole-archive removal. Can it be fixed by
adding linking with the static ICU with whole-archive option instead of
manual exporting of each symbol, like it was before?
next prev parent reply other threads:[~2020-09-28 6:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 11:02 HustonMmmavr
2020-09-24 21:10 ` Vladislav Shpilevoy
2020-09-27 22:39 ` Alexandr Barulev
2020-09-28 6:26 ` Vladislav Shpilevoy [this message]
2020-10-01 3:19 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861c8e85-83f0-6640-75bc-7f5d923c4f47@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=huston.mavr@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=yaroslav.dynnikov@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH v2] Add missed icu symbols' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox