From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7AB28469719 for ; Mon, 28 Sep 2020 09:26:07 +0300 (MSK) References: <20200923110251.33201-1-huston.mavr@gmail.com> From: Vladislav Shpilevoy Message-ID: <861c8e85-83f0-6640-75bc-7f5d923c4f47@tarantool.org> Date: Mon, 28 Sep 2020 08:26:05 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v2] Add missed icu symbols List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexandr Barulev Cc: Alexander Turenko , tarantool-patches@dev.tarantool.org, Yaroslav Dynnikov On 28.09.2020 00:39, Alexandr Barulev wrote: > Hello, thanks for the review of new patch version! > > I've fixed commit message (added `build` prefix) and rebased > from master. > > I think commit, mentionied at patch message ("cmake: remove > dynamic-list linker option") is related to #5266 issue. > It's because symbols exports from required libs into tarantool binary > earlier were configured with two options: > by `--whole-archive` option; > and `--dynamic-list,${exports_file}` option, where exports_file was created > with use of mkexports script (symbols was grabbed by nm -D from shared > libraries). > > Also, I've checkouted "cmake: remove dynamic-list linker option" > commit, built static tarantool and ran icu-date tests. In result > tests failed with `undefined symbol` errors. > After that, I checkouted previous commit, built tarantool again > and icu-date tests succeed Ok, so this is because of whole-archive removal. Can it be fixed by adding linking with the static ICU with whole-archive option instead of manual exporting of each symbol, like it was before?