From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: HustonMmmavr <huston.mavr@gmail.com>,
tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@gmail.com,
alexander.turenko@tarantool.org, tsafin@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] Add missed icu symbols
Date: Thu, 24 Sep 2020 23:10:34 +0200 [thread overview]
Message-ID: <f9d13bc4-620d-302d-ed78-31675d8ef2a5@tarantool.org> (raw)
In-Reply-To: <20200923110251.33201-1-huston.mavr@gmail.com>
Hi! Thanks for the patch!
I would add 'build: ' prefix to the commit message.
On 23.09.2020 13:02, HustonMmmavr wrote:
> After patch 03790ac5510648d1d9648bb2281857a7992d0593 ("cmake: remove
> dynamic-list linker option") symbols exports was changed (now we have
> to export required symbols manually).
Actually after some thinking I am not sure it is because of that commit.
Symbols exports were always done manually. That commit changed which
symbols were hidden. So essentially it extended the exported symbols
set, not shrunk it.
And that makes me wonder how could it lead to #5266?
> Icu symbols, required by icu-date
> rock (as ffi calls) are unused at linkage stage of tarantool binary
> and thrown away from it so icu-date won't work (in case of tarantool
> static build).
They would have been thrown anyway. It is not related to the dynamic-list
option removed in the mentioned commit.
> This patch fixes this behaviour by adding symbols
> required by icu-date rock to symbols export list.
>
> Close #5266
next prev parent reply other threads:[~2020-09-24 21:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 11:02 HustonMmmavr
2020-09-24 21:10 ` Vladislav Shpilevoy [this message]
2020-09-27 22:39 ` Alexandr Barulev
2020-09-28 6:26 ` Vladislav Shpilevoy
2020-10-01 3:19 ` Alexander Turenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9d13bc4-620d-302d-ed78-31675d8ef2a5@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=huston.mavr@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=tsafin@tarantool.org \
--cc=yaroslav.dynnikov@gmail.com \
--subject='Re: [Tarantool-patches] [PATCH v2] Add missed icu symbols' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox