From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 4/4] dbg: introduce lj-bc, lj-func and lj-proto dumpers
Date: Fri, 5 Jun 2026 18:07:05 +0300 [thread overview]
Message-ID: <74ca0f6d-1db0-4e62-a4c0-e19986d31c34@tarantool.org> (raw)
In-Reply-To: <20260604093052.2221827-5-skaplun@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
Hi, Sergey,
thanks for the patch! LGTM with a minor comment.
Sergey
On 6/4/26 12:30, Sergey Kaplun wrote:
<snipped>
> +
> +
> +def bcmode_cd(op):
> + return int((lj_bc_mode()[op] >> 7) & 15)
> +
> +
> +# Unfortunately, there is no place in the VM except the generated
> +# Lua table, where the bytecode names are stored. So duplicate
> +# them here.
> +BYTECODES = [
> + # Comparison ops. ORDER OPR.
"ORDER OPR" - what does it mean? Here and below.
> + 'ISLT',
> + 'ISGE',
> + 'ISLE',
<snipped>
>
[-- Attachment #2: Type: text/html, Size: 1333 bytes --]
next prev parent reply other threads:[~2026-06-05 15:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 9:30 [Tarantool-patches] [PATCH luajit 0/4] Introduce dumpers for bytecodes in debuggers Sergey Kaplun via Tarantool-patches
2026-06-04 9:30 ` [Tarantool-patches] [PATCH luajit 1/4] dbg: fix lj-stack command for LLDB Sergey Kaplun via Tarantool-patches
2026-06-05 14:55 ` Sergey Bronnikov via Tarantool-patches
2026-06-04 9:30 ` [Tarantool-patches] [PATCH luajit 2/4] dbg: fix DUALNUM detection " Sergey Kaplun via Tarantool-patches
2026-06-05 14:57 ` Sergey Bronnikov via Tarantool-patches
2026-06-05 16:01 ` Sergey Kaplun via Tarantool-patches
2026-06-04 9:30 ` [Tarantool-patches] [PATCH luajit 3/4] dbg: introduce lj-gco command Sergey Kaplun via Tarantool-patches
2026-06-05 15:02 ` Sergey Bronnikov via Tarantool-patches
2026-06-04 9:30 ` [Tarantool-patches] [PATCH luajit 4/4] dbg: introduce lj-bc, lj-func and lj-proto dumpers Sergey Kaplun via Tarantool-patches
2026-06-05 15:07 ` Sergey Bronnikov via Tarantool-patches [this message]
2026-06-05 16:10 ` Sergey Kaplun via Tarantool-patches
2026-06-05 14:55 ` [Tarantool-patches] [PATCH luajit 0/4] Introduce dumpers for bytecodes in debuggers Sergey Bronnikov via Tarantool-patches
2026-06-05 16:03 ` [Tarantool-patches] [PATCH luajit 3/5] dbg: update help for the lj-arch command Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74ca0f6d-1db0-4e62-a4c0-e19986d31c34@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=e.temirgaleev@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 4/4] dbg: introduce lj-bc, lj-func and lj-proto dumpers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox