From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5018F6ECCC; Fri, 5 Jun 2026 18:07:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5018F6ECCC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1780672028; bh=2cSoMEWvQKrAD8vA4FrxgfYsX4j09kQ1GSvtKiCEYpI=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=PqxPJBkIc4gdI+Wj0R5kIXXKPTpZgS4fZ7P8lr1QV/JnryWfubEvD2MbKvB1IpoEk sH7EkqGzuawr+oxcOjnjWEp7zuUEZd4rSltE6HK1cPr6n0rAsRogjNblrsJDHUu/V5 rbfCUF6FwJTRSQYM7vkFcNRKKX9X/n4vJJzVzl/k= Received: from send103.i.mail.ru (send103.i.mail.ru [89.221.237.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2FD8C6ECCC for ; Fri, 5 Jun 2026 18:07:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2FD8C6ECCC Received: by exim-smtp-85dd497b6-w2vlf with esmtpa (envelope-from ) id 1wVW8Y-00000000K2C-0zev; Fri, 05 Jun 2026 18:07:06 +0300 Content-Type: multipart/alternative; boundary="------------Z1Vjd5J9R3STIIABlNqLSLPK" Message-ID: <74ca0f6d-1db0-4e62-a4c0-e19986d31c34@tarantool.org> Date: Fri, 5 Jun 2026 18:07:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Evgeniy Temirgaleev Cc: tarantool-patches@dev.tarantool.org References: <20260604093052.2221827-1-skaplun@tarantool.org> <20260604093052.2221827-5-skaplun@tarantool.org> In-Reply-To: <20260604093052.2221827-5-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9FAD06046D747065B5E501D0605CEA84C9D2B5AB1DD9DE79A182A05F53808504072A11E81AA45A6A43DE06ABAFEAF670506D9A77BFCEB86BF6F09AD58D3BD14389797BF2D09611BC0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FBB2043146276655EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB5533756660A56BB7F6F20B60861F207F23564B2843AAE49459C38C62A6CB3C4993D04979389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B652D31B9D28593E51CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7F45C1E71A9DFFA2A731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5D4DE40441E1A3C795002B1117B3ED69648290B270B10710ACA7E60A991436CA2823CB91A9FED034534781492E4B8EEAD27E9584FBD6BDD31BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659214CDED90092E271D280095BE1F5839AED7C46561E71451CD8162F04E6EE67FC3BECA66E6732D087B8341EE9D5BE9A0AC0D6EC14E7D5BAA6D3EC64276C73645F45A07B9D26E1E6996536EB022892E5344C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVRI2994ruhLUG4A2UFRcSkU= X-DA7885C5: BBA7FE69CB28438EF255D290C0D534F92CA6DFE864A38E2708F9D435A4327327DD860F4E70D31E8F5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE23A03F474F943483CCADD77BEE6F70F8BD3E6587E07570243EF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 4/4] dbg: introduce lj-bc, lj-func and lj-proto dumpers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------Z1Vjd5J9R3STIIABlNqLSLPK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! LGTM with a minor comment. Sergey On 6/4/26 12:30, Sergey Kaplun wrote: > + > + > +def bcmode_cd(op): > + return int((lj_bc_mode()[op] >> 7) & 15) > + > + > +# Unfortunately, there is no place in the VM except the generated > +# Lua table, where the bytecode names are stored. So duplicate > +# them here. > +BYTECODES = [ > + # Comparison ops. ORDER OPR. "ORDER OPR" - what does it mean? Here and below. > + 'ISLT', > + 'ISGE', > + 'ISLE', > --------------Z1Vjd5J9R3STIIABlNqLSLPK Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! LGTM with a minor comment.

Sergey

On 6/4/26 12:30, Sergey Kaplun wrote:


<snipped>

+
+
+def bcmode_cd(op):
+    return int((lj_bc_mode()[op] >> 7) & 15)
+
+
+# Unfortunately, there is no place in the VM except the generated
+# Lua table, where the bytecode names are stored. So duplicate
+# them here.
+BYTECODES = [
+    # Comparison ops. ORDER OPR.
"ORDER OPR" - what does it mean? Here and below. 
+    'ISLT',
+    'ISGE',
+    'ISLE',
<snipped>
--------------Z1Vjd5J9R3STIIABlNqLSLPK--