From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 5/7] sql: remove implicit cast from OP_MakeRecord
Date: Fri, 6 Aug 2021 02:13:37 +0200 [thread overview]
Message-ID: <6e3ea4ae-7be4-b71a-3f22-f16252fea727@tarantool.org> (raw)
In-Reply-To: <20210805234319.GE81912@tarantool.org>
Thanks for the patch!
> diff --git a/changelogs/unreleased/gh-4230-implicit-cast-for-comparison.md b/changelogs/unreleased/gh-4230-implicit-cast-for-comparison.md
> new file mode 100644
> index 000000000..66103f461
> --- /dev/null
> +++ b/changelogs/unreleased/gh-4230-implicit-cast-for-comparison.md
> @@ -0,0 +1,6 @@
> +## feature/sql
> +
> +* Now any number can be compared to any other number, and values of any scalar
> + type can be compared to any other value of the same type. A value of a
> + non-numeric scalar type cannot be compared with a value of any other scalar
> + type (gh-4230).
> \ No newline at end of file
Please, add an empty line in the end of the file.
After this and the other similar comment in other commit
the patchset LGTM.
next prev parent reply other threads:[~2021-08-06 0:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 20:51 [Tarantool-patches] [PATCH v1 0/7] Rework implicit cast Mergen Imeev via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 1/7] sql: rework implicit cast fo assignment Mergen Imeev via Tarantool-patches
2021-07-30 21:55 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-04 22:21 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:27 ` Mergen Imeev via Tarantool-patches
2021-08-06 0:13 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 2/7] sql: remove implicit cast from comparison opcodes Mergen Imeev via Tarantool-patches
2021-08-04 22:24 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:33 ` Mergen Imeev via Tarantool-patches
2021-08-06 0:13 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 3/7] sql: rework OP_Seek* opcodes Mergen Imeev via Tarantool-patches
2021-08-04 22:25 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:40 ` Mergen Imeev via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 4/7] sql: remove unnecessary calls of OP_ApplyType Mergen Imeev via Tarantool-patches
2021-08-04 22:26 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:41 ` Mergen Imeev via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 5/7] sql: remove implicit cast from OP_MakeRecord Mergen Imeev via Tarantool-patches
2021-08-04 22:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:43 ` Mergen Imeev via Tarantool-patches
2021-08-06 0:13 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 6/7] sql: remove implicit cast from OP_MustBeInt Mergen Imeev via Tarantool-patches
2021-08-05 23:47 ` Mergen Imeev via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 7/7] sql: remove unused MEM cast functions Mergen Imeev via Tarantool-patches
2021-08-04 22:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:45 ` Mergen Imeev via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e3ea4ae-7be4-b71a-3f22-f16252fea727@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 5/7] sql: remove implicit cast from OP_MakeRecord' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox