From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/7] sql: rework implicit cast fo assignment
Date: Thu, 5 Aug 2021 00:21:39 +0200 [thread overview]
Message-ID: <ea962690-bf14-dfae-7364-7aab8a72fb93@tarantool.org> (raw)
In-Reply-To: <8a2c3321-0251-56b5-cc47-475a407c722f@tarantool.org>
Hi! These comments still need attention.
On 30.07.2021 23:55, Vladislav Shpilevoy via Tarantool-patches wrote:
> Thanks for the patch!
>
> I will return later to continue the review of the next commits.
> Sending first comments so as I could switch to other patches.
>
> See 10 comments below.
next prev parent reply other threads:[~2021-08-04 22:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 20:51 [Tarantool-patches] [PATCH v1 0/7] Rework implicit cast Mergen Imeev via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 1/7] sql: rework implicit cast fo assignment Mergen Imeev via Tarantool-patches
2021-07-30 21:55 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-04 22:21 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-08-05 23:27 ` Mergen Imeev via Tarantool-patches
2021-08-06 0:13 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 2/7] sql: remove implicit cast from comparison opcodes Mergen Imeev via Tarantool-patches
2021-08-04 22:24 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:33 ` Mergen Imeev via Tarantool-patches
2021-08-06 0:13 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 3/7] sql: rework OP_Seek* opcodes Mergen Imeev via Tarantool-patches
2021-08-04 22:25 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:40 ` Mergen Imeev via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 4/7] sql: remove unnecessary calls of OP_ApplyType Mergen Imeev via Tarantool-patches
2021-08-04 22:26 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:41 ` Mergen Imeev via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 5/7] sql: remove implicit cast from OP_MakeRecord Mergen Imeev via Tarantool-patches
2021-08-04 22:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:43 ` Mergen Imeev via Tarantool-patches
2021-08-06 0:13 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 6/7] sql: remove implicit cast from OP_MustBeInt Mergen Imeev via Tarantool-patches
2021-08-05 23:47 ` Mergen Imeev via Tarantool-patches
2021-07-28 20:51 ` [Tarantool-patches] [PATCH v1 7/7] sql: remove unused MEM cast functions Mergen Imeev via Tarantool-patches
2021-08-04 22:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-05 23:45 ` Mergen Imeev via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea962690-bf14-dfae-7364-7aab8a72fb93@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 1/7] sql: rework implicit cast fo assignment' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox