From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DF0EC741EC; Fri, 6 Aug 2021 03:14:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DF0EC741EC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628208877; bh=pg9DsaifdHeypEJ2f65IxQ+JzMxBoCMKdtjkwDwudXs=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=O/Pkg2toyDxHKPtGAAWiM8OvOjc+femtsqAZRp1G/VB2SbiXcGNJ3txWMgUmm2SNy pLk1lwAZox77ibzSSwwOkSbNNa1XoWQQwf9FE9OUnDA1vuJJJ361vQmm11juRcSvLM Qd9bN81joV/PoLgqqa2/MXe8AJZRrAnN+PkVZDjc= Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9DE64741EE for ; Fri, 6 Aug 2021 03:13:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9DE64741EE Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1mBnUY-0005R9-0S; Fri, 06 Aug 2021 03:13:38 +0300 To: Mergen Imeev Cc: tarantool-patches@dev.tarantool.org References: <20210805234319.GE81912@tarantool.org> Message-ID: <6e3ea4ae-7be4-b71a-3f22-f16252fea727@tarantool.org> Date: Fri, 6 Aug 2021 02:13:37 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210805234319.GE81912@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9D5AC6413C25DCF08E2C99C00A2DD9947182A05F538085040D5524619A0BC4108718D1F8C99BBEF42C2F8663233B89734D97764482E701C4C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78E8764B5BC580342EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063721BEEAF38C6AE0B78638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80FF12B0D222C51E5E6E2A6D50AD231D5117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC292D688DDAD4E7BC389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8FE4D9CDE3FF759CFF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CA0BCD6C998BE2772302FCEF25BFAB3454AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C3C30C415A873EAD8ABA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE72F88032165008D51731C566533BA786AA5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458F0AFF96BAACF4158235E5A14AD4A4A4625E192CAD1D9E79D94463893BF8742D0BBB16C35E65F6332 X-C1DE0DAB: 0D63561A33F958A518814306C988124B848FDCB27C36E385E2D8720A0C7EAFB2D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3452F7993FB7281BFD7C717FBFEE709A8040A77D071C088E0AFA48682B25C869117AF6C677FE96EC811D7E09C32AA3244CEF359D1DC8305BD840442AB7FF70ED7EFE8DA44ABE2443F7729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFhlvmGwdUwRtJpkDH7VmSw== X-Mailru-Sender: 1F3202E75A95DDEFC23907419AE0C7D763085A98BD5F3563BBD01491899B30403120E6DF4C99E0C907784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 5/7] sql: remove implicit cast from OP_MakeRecord X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! > diff --git a/changelogs/unreleased/gh-4230-implicit-cast-for-comparison.md b/changelogs/unreleased/gh-4230-implicit-cast-for-comparison.md > new file mode 100644 > index 000000000..66103f461 > --- /dev/null > +++ b/changelogs/unreleased/gh-4230-implicit-cast-for-comparison.md > @@ -0,0 +1,6 @@ > +## feature/sql > + > +* Now any number can be compared to any other number, and values of any scalar > + type can be compared to any other value of the same type. A value of a > + non-numeric scalar type cannot be compared with a value of any other scalar > + type (gh-4230). > \ No newline at end of file Please, add an empty line in the end of the file. After this and the other similar comment in other commit the patchset LGTM.