From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>,
tarantool-patches@dev.tarantool.org, gorcunov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH 04/12] raft: stop using replication_synchro_quorum
Date: Fri, 20 Nov 2020 00:42:29 +0100 [thread overview]
Message-ID: <6c567dac-842d-4aea-7511-ed899167d33b@tarantool.org> (raw)
In-Reply-To: <fc076a81-8019-5b64-ab4a-5fda385120cf@tarantool.org>
Hi! Thanks for the review!
>> diff --git a/src/box/raft.c b/src/box/raft.c
>> index f289a6993..af6e71e0b 100644
>> --- a/src/box/raft.c
>> +++ b/src/box/raft.c
>> @@ -62,6 +63,57 @@ box_raft_on_update_f(struct trigger *trigger, void *event)
>> return 0;
>> }
>>
>> +void
>> +box_raft_reconsider_election_quorum(void)
>
> Suggestion: maybe use "rewrite"/"reset" instead of "reconsider"?
> Or plain "update"?
>
> Other than that, LGTM.
I took "update". Now it is box_raft_update_election_quorum().
next prev parent reply other threads:[~2020-11-19 23:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 0:02 [Tarantool-patches] [PATCH 00/12] Raft module, part 2 - relocation to src/lib/raft Vladislav Shpilevoy
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 01/12] raft: move sources to raftlib.h/.c Vladislav Shpilevoy
2020-11-17 8:14 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 10/12] raft: move box_update_ro_summary to update trigger Vladislav Shpilevoy
2020-11-17 12:42 ` Serge Petrenko
2020-11-17 15:17 ` Serge Petrenko
2020-11-18 23:21 ` Vladislav Shpilevoy
2020-11-19 10:08 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 11/12] raft: introduce RaftError Vladislav Shpilevoy
2020-11-17 15:13 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 12/12] raft: move algorithm code to src/lib/raft Vladislav Shpilevoy
2020-11-17 15:13 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 02/12] raft: move box_raft_* to src/box/raft.h and .c Vladislav Shpilevoy
2020-11-17 8:14 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 03/12] raft: stop using replication_disconnect_timeout() Vladislav Shpilevoy
2020-11-17 8:15 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 04/12] raft: stop using replication_synchro_quorum Vladislav Shpilevoy
2020-11-17 8:17 ` Serge Petrenko
2020-11-19 23:42 ` Vladislav Shpilevoy [this message]
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 05/12] raft: stop using instance_id Vladislav Shpilevoy
2020-11-17 8:59 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 06/12] raft: make raft_request.vclock constant Vladislav Shpilevoy
2020-11-17 9:17 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 07/12] raft: stop using replicaset.vclock Vladislav Shpilevoy
2020-11-17 9:23 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 08/12] raft: introduce vtab for disk and network Vladislav Shpilevoy
2020-11-17 9:35 ` Serge Petrenko
2020-11-19 23:43 ` Vladislav Shpilevoy
2020-11-17 10:00 ` Serge Petrenko
2020-11-19 23:43 ` Vladislav Shpilevoy
2020-11-20 7:56 ` Serge Petrenko
2020-11-20 19:40 ` Vladislav Shpilevoy
2020-11-23 8:09 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 09/12] raft: introduce raft_msg, drop xrow dependency Vladislav Shpilevoy
2020-11-17 10:22 ` Serge Petrenko
2020-11-19 23:43 ` Vladislav Shpilevoy
2020-11-20 8:03 ` Serge Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c567dac-842d-4aea-7511-ed899167d33b@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 04/12] raft: stop using replication_synchro_quorum' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox