From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org, gorcunov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH 08/12] raft: introduce vtab for disk and network
Date: Mon, 23 Nov 2020 11:09:04 +0300 [thread overview]
Message-ID: <c8a38471-60e8-e813-37c7-0e7b8905a2da@tarantool.org> (raw)
In-Reply-To: <a5f064bd-f7be-8e30-4fc4-32a9a796f779@tarantool.org>
20.11.2020 22:40, Vladislav Shpilevoy пишет:
>>>>> diff --git a/src/box/raft.c b/src/box/raft.c
>>>>> index af6e71e0b..845525660 100644
>>>>> --- a/src/box/raft.c
>>>>> +++ b/src/box/raft.c
>>>>> @@ -29,7 +29,10 @@
>>>>> * SUCH DAMAGE.
>>>>> */
>>>>> #include "box.h"
>>>>> +#include "error.h"
>>>>> +#include "journal.h"
>>>>> #include "raft.h"
>>>>> +#include "relay.h"
>>>>> #include "replication.h"
>>>> Just noticed: raft.c starts depending on xrow.h in this patch.
>>> This is fine. box/raft.c can depend on anything. It is raftlib.c/.h,
>>> who is not allowed to depend on anything except src/lib.
>> I meant you should include xrow.h here directly.
> Aha, ok. I thought that it is enough to have it implicitly through other
> files. But I don't mind adding it.
>
> ====================
> @@ -34,6 +34,7 @@
> #include "raft.h"
> #include "relay.h"
> #include "replication.h"
> +#include "xrow.h"
Thanks for the change!
Yes, it's enough to have it included in some other file, but AFAIR we always
include dependencies directly. Either in raft.h (if needed) or raft.c in
this case.
I may be mistaken though.
--
Serge Petrenko
next prev parent reply other threads:[~2020-11-23 8:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 0:02 [Tarantool-patches] [PATCH 00/12] Raft module, part 2 - relocation to src/lib/raft Vladislav Shpilevoy
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 01/12] raft: move sources to raftlib.h/.c Vladislav Shpilevoy
2020-11-17 8:14 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 10/12] raft: move box_update_ro_summary to update trigger Vladislav Shpilevoy
2020-11-17 12:42 ` Serge Petrenko
2020-11-17 15:17 ` Serge Petrenko
2020-11-18 23:21 ` Vladislav Shpilevoy
2020-11-19 10:08 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 11/12] raft: introduce RaftError Vladislav Shpilevoy
2020-11-17 15:13 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 12/12] raft: move algorithm code to src/lib/raft Vladislav Shpilevoy
2020-11-17 15:13 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 02/12] raft: move box_raft_* to src/box/raft.h and .c Vladislav Shpilevoy
2020-11-17 8:14 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 03/12] raft: stop using replication_disconnect_timeout() Vladislav Shpilevoy
2020-11-17 8:15 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 04/12] raft: stop using replication_synchro_quorum Vladislav Shpilevoy
2020-11-17 8:17 ` Serge Petrenko
2020-11-19 23:42 ` Vladislav Shpilevoy
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 05/12] raft: stop using instance_id Vladislav Shpilevoy
2020-11-17 8:59 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 06/12] raft: make raft_request.vclock constant Vladislav Shpilevoy
2020-11-17 9:17 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 07/12] raft: stop using replicaset.vclock Vladislav Shpilevoy
2020-11-17 9:23 ` Serge Petrenko
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 08/12] raft: introduce vtab for disk and network Vladislav Shpilevoy
2020-11-17 9:35 ` Serge Petrenko
2020-11-19 23:43 ` Vladislav Shpilevoy
2020-11-17 10:00 ` Serge Petrenko
2020-11-19 23:43 ` Vladislav Shpilevoy
2020-11-20 7:56 ` Serge Petrenko
2020-11-20 19:40 ` Vladislav Shpilevoy
2020-11-23 8:09 ` Serge Petrenko [this message]
2020-11-17 0:02 ` [Tarantool-patches] [PATCH 09/12] raft: introduce raft_msg, drop xrow dependency Vladislav Shpilevoy
2020-11-17 10:22 ` Serge Petrenko
2020-11-19 23:43 ` Vladislav Shpilevoy
2020-11-20 8:03 ` Serge Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8a38471-60e8-e813-37c7-0e7b8905a2da@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 08/12] raft: introduce vtab for disk and network' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox