From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E1D33469710 for ; Fri, 20 Nov 2020 02:42:31 +0300 (MSK) From: Vladislav Shpilevoy References: Message-ID: <6c567dac-842d-4aea-7511-ed899167d33b@tarantool.org> Date: Fri, 20 Nov 2020 00:42:29 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 04/12] raft: stop using replication_synchro_quorum List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko , tarantool-patches@dev.tarantool.org, gorcunov@gmail.com Hi! Thanks for the review! >> diff --git a/src/box/raft.c b/src/box/raft.c >> index f289a6993..af6e71e0b 100644 >> --- a/src/box/raft.c >> +++ b/src/box/raft.c >> @@ -62,6 +63,57 @@ box_raft_on_update_f(struct trigger *trigger, void *event) >> return 0; >> } >> >> +void >> +box_raft_reconsider_election_quorum(void) > > Suggestion: maybe use "rewrite"/"reset" instead of "reconsider"? > Or plain "update"? > > Other than that, LGTM. I took "update". Now it is box_raft_update_election_quorum().