Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/3] sql: introduce uuid to quote()
Date: Wed, 7 Jul 2021 23:41:51 +0200	[thread overview]
Message-ID: <6690e773-0750-79d0-2eca-f7d5f94ef71d@tarantool.org> (raw)
In-Reply-To: <9f12b130a632224a7783e516c182febeecef4fb9.1625497228.git.imeevma@gmail.com>

Hi! Thanks for the patch!

> diff --git a/test/sql-tap/gh-6164-uuid-follow-ups.test.lua b/test/sql-tap/gh-6164-uuid-follow-ups.test.lua
> new file mode 100755
> index 000000000..d8fa700ea
> --- /dev/null
> +++ b/test/sql-tap/gh-6164-uuid-follow-ups.test.lua

1. The test runs 2 times with 2 engines. Please, make it work only
once. It does not depend on an engine anyway.

> @@ -0,0 +1,16 @@
> +#!/usr/bin/env tarantool
> +local test = require("sqltester")
> +test:plan(1)
> +
> +box.execute([[select quote(cast('11111111-1111-1111-1111-111111111111' as uuid));]])

2. Why do you need this select? Isn't it exactly the same as the SELECT below?

> +
> +-- Make sure that function quote() can work with uuid.
> +test:do_execsql_test(
> +    "gh-6164-1",
> +    [[
> +        SELECT quote(cast('11111111-1111-1111-1111-111111111111' as uuid));
> +    ]], {
> +        '11111111-1111-1111-1111-111111111111'
> +    })
> +
> +test:finish_test()

  reply	other threads:[~2021-07-07 21:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 15:04 [Tarantool-patches] [PATCH v1 0/3] Follow ups for uuid introduction Mergen Imeev via Tarantool-patches
2021-07-05 15:06 ` [Tarantool-patches] [PATCH v1 1/3] sql: introduce uuid to quote() Mergen Imeev via Tarantool-patches
2021-07-07 21:41   ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-07-05 15:06 ` [Tarantool-patches] [PATCH v1 2/3] sql: fix uuid behaviour in least() and greatest() Mergen Imeev via Tarantool-patches
2021-07-07 21:42   ` Vladislav Shpilevoy via Tarantool-patches
2021-07-10 14:36     ` Mergen Imeev via Tarantool-patches
2021-07-05 15:06 ` [Tarantool-patches] [PATCH v1 3/3] sql: allow to bind uuid values Mergen Imeev via Tarantool-patches
2021-07-07 21:44   ` Vladislav Shpilevoy via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6690e773-0750-79d0-2eca-f7d5f94ef71d@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 1/3] sql: introduce uuid to quote()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox