Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 2/3] sql: fix uuid behaviour in least() and greatest()
Date: Wed, 7 Jul 2021 23:42:16 +0200	[thread overview]
Message-ID: <f21280fd-8774-e07a-007b-cbfa6983f3b6@tarantool.org> (raw)
In-Reply-To: <ad5229b069c8fefe8b9e7510e0ac42e25b5939d2.1625497228.git.imeevma@gmail.com>

Thanks for the patch!

> diff --git a/test/sql-tap/gh-6164-uuid-follow-ups.test.lua b/test/sql-tap/gh-6164-uuid-follow-ups.test.lua
> index d8fa700ea..8872f9f23 100755
> --- a/test/sql-tap/gh-6164-uuid-follow-ups.test.lua
> +++ b/test/sql-tap/gh-6164-uuid-follow-ups.test.lua
> @@ -13,4 +15,21 @@ test:do_execsql_test(
>          '11111111-1111-1111-1111-111111111111'
>      })
>  
> +-- Make sure that functions greatest() and least() can properly work with uuid.
> +test:do_execsql_test(
> +    "gh-6164-2",
> +    [[
> +        SELECT GREATEST(true, 1, x'33', cast('11111111-1111-1111-1111-111111111111' as uuid), 1e10);

Please, try to remain inside 80 symbols line width limit. The same below.

> +    ]], {
> +        uuid
> +    })
> +
> +test:do_execsql_test(
> +    "gh-6164-3",
> +    [[
> +        SELECT LEAST(true, 1, x'33', cast('11111111-1111-1111-1111-111111111111' as uuid), 1e10);
> +    ]], {
> +        true
> +    })
> +
>  test:finish_test()
> 

  reply	other threads:[~2021-07-07 21:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 15:04 [Tarantool-patches] [PATCH v1 0/3] Follow ups for uuid introduction Mergen Imeev via Tarantool-patches
2021-07-05 15:06 ` [Tarantool-patches] [PATCH v1 1/3] sql: introduce uuid to quote() Mergen Imeev via Tarantool-patches
2021-07-07 21:41   ` Vladislav Shpilevoy via Tarantool-patches
2021-07-05 15:06 ` [Tarantool-patches] [PATCH v1 2/3] sql: fix uuid behaviour in least() and greatest() Mergen Imeev via Tarantool-patches
2021-07-07 21:42   ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-07-10 14:36     ` Mergen Imeev via Tarantool-patches
2021-07-05 15:06 ` [Tarantool-patches] [PATCH v1 3/3] sql: allow to bind uuid values Mergen Imeev via Tarantool-patches
2021-07-07 21:44   ` Vladislav Shpilevoy via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f21280fd-8774-e07a-007b-cbfa6983f3b6@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 2/3] sql: fix uuid behaviour in least() and greatest()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox