From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 56F126EC40; Thu, 8 Jul 2021 00:41:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 56F126EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625694114; bh=uGT0HsZ+QLsL0orSa++dPLy5bypXTXHtZ0jdUt0mVr0=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hHyzgq1fn73bog0gXnBfj0nXVttGksNhkqCLAisb5z8RUrjcJrHQ7uwaYZkA7ik7K qZaX4AvJv05KV+6h4AjxXdnclKETZAX3CH/+GKwAqgkXxwYS1C9EZGFb7L0t8JmMcd OXW6iazZPs8i2ct54OD1LSkdummoEWcK89Id5zRo= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 732906EC40 for ; Thu, 8 Jul 2021 00:41:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 732906EC40 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1m1FIm-0005q6-Jg; Thu, 08 Jul 2021 00:41:53 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <9f12b130a632224a7783e516c182febeecef4fb9.1625497228.git.imeevma@gmail.com> Message-ID: <6690e773-0750-79d0-2eca-f7d5f94ef71d@tarantool.org> Date: Wed, 7 Jul 2021 23:41:51 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <9f12b130a632224a7783e516c182febeecef4fb9.1625497228.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB703477AD6D36A6E3513B6A65BE508F5F182A05F53808504088DAF76D7C147B47895186E3FA1DBB2D24EE83B7FAD8F3DC953AA984B73D8748 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE741C078103BC1EE25EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375FE8AD9F0D2764EB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D81CED449CD314A2F54D90D97116240E11117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A1DCCEB63E2F10FB089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5C362CB8968DD2EA7EB7C1364955E6057103CDA927135587FD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753753CEE10E4ED4A7410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D341ADA1A41A420E9B2460DDC2B6B9999F2B22E369768E55147166D9D98D6A518BA4903A1E7A4EA64201D7E09C32AA3244C2EAA2FCAD6DA9C6EAE0E0E2D8958AEEF7C0C08F7987826B9729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojwWhFrYo6Pn3YSImECjFIMA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DF8126E7794B931E7BE71AFB4227DFEB83841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/3] sql: introduce uuid to quote() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! > diff --git a/test/sql-tap/gh-6164-uuid-follow-ups.test.lua b/test/sql-tap/gh-6164-uuid-follow-ups.test.lua > new file mode 100755 > index 000000000..d8fa700ea > --- /dev/null > +++ b/test/sql-tap/gh-6164-uuid-follow-ups.test.lua 1. The test runs 2 times with 2 engines. Please, make it work only once. It does not depend on an engine anyway. > @@ -0,0 +1,16 @@ > +#!/usr/bin/env tarantool > +local test = require("sqltester") > +test:plan(1) > + > +box.execute([[select quote(cast('11111111-1111-1111-1111-111111111111' as uuid));]]) 2. Why do you need this select? Isn't it exactly the same as the SELECT below? > + > +-- Make sure that function quote() can work with uuid. > +test:do_execsql_test( > + "gh-6164-1", > + [[ > + SELECT quote(cast('11111111-1111-1111-1111-111111111111' as uuid)); > + ]], { > + '11111111-1111-1111-1111-111111111111' > + }) > + > +test:finish_test()