From: Serge Petrenko <sergepetrenko@tarantool.org> To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH 00/10] Raft module, part 3 - fake network and libev for Raft and SWIM Date: Tue, 1 Dec 2020 16:42:20 +0300 [thread overview] Message-ID: <6465ac03-2c3a-63e6-7392-df0543a072d0@tarantool.org> (raw) In-Reply-To: <cover.1606780408.git.v.shpilevoy@tarantool.org> 01.12.2020 02:56, Vladislav Shpilevoy пишет: > The patchset is a third part of Raft relocation to a new module for the sake of > unit testing. This part extracts fake network and libev libraries from SWIM unit > tests to a new library fakesys, which will be used by Raft. > > The patchset only moves the existing code. For the actual Raft tests it is > likely I will add some new Raft-specific code, and probably will generalize > something from swim_test_utils.h/.c. > > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5303-p3-fakesys > Issue: https://github.com/tarantool/tarantool/issues/5303 Hi! Thanks for the patchset! LGTM. > Vladislav Shpilevoy (10): > test: stop using swim_transport.addr as in-param > test: factor out swim from libc emulation funcs > test: rename fake libc network methods to fakenet > test: move fake network code to fakenet.c/.h files > test: factor out swim from fakenet.c/.h files > fakesys: introduce fake system library > test: rename fake libev methods to fakeev > test: move fake libev code to fakeev.c/.h files > test: factor out swim from fakeev.h/.c files > fakesys: move fakeev to fakesys library > > src/lib/CMakeLists.txt | 1 + > src/lib/fakesys/CMakeLists.txt | 8 + > src/lib/fakesys/fakeev.c | 350 ++++++++++++ > .../lib/fakesys/fakeev.h | 45 +- > src/lib/fakesys/fakenet.c | 502 ++++++++++++++++++ > .../lib/fakesys/fakenet.h | 81 ++- > test/unit/CMakeLists.txt | 6 +- > test/unit/swim.c | 8 +- > test/unit/swim_errinj.c | 8 +- > test/unit/swim_test_ev.c | 319 +---------- > test/unit/swim_test_transport.c | 438 +-------------- > test/unit/swim_test_utils.c | 30 +- > test/unit/swim_test_utils.h | 6 +- > 13 files changed, 1003 insertions(+), 799 deletions(-) > create mode 100644 src/lib/fakesys/CMakeLists.txt > create mode 100644 src/lib/fakesys/fakeev.c > rename test/unit/swim_test_ev.h => src/lib/fakesys/fakeev.h (77%) > create mode 100644 src/lib/fakesys/fakenet.c > rename test/unit/swim_test_transport.h => src/lib/fakesys/fakenet.h (59%) > -- Serge Petrenko
next prev parent reply other threads:[~2020-12-01 13:42 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-30 23:56 Vladislav Shpilevoy 2020-11-30 23:56 ` [Tarantool-patches] [PATCH 01/10] test: stop using swim_transport.addr as in-param Vladislav Shpilevoy 2020-11-30 23:56 ` [Tarantool-patches] [PATCH 10/10] fakesys: move fakeev to fakesys library Vladislav Shpilevoy 2020-11-30 23:56 ` [Tarantool-patches] [PATCH 02/10] test: factor out swim from libc emulation funcs Vladislav Shpilevoy 2020-11-30 23:56 ` [Tarantool-patches] [PATCH 03/10] test: rename fake libc network methods to fakenet Vladislav Shpilevoy 2020-11-30 23:56 ` [Tarantool-patches] [PATCH 04/10] test: move fake network code to fakenet.c/.h files Vladislav Shpilevoy 2020-11-30 23:56 ` [Tarantool-patches] [PATCH 05/10] test: factor out swim from " Vladislav Shpilevoy 2020-11-30 23:56 ` [Tarantool-patches] [PATCH 06/10] fakesys: introduce fake system library Vladislav Shpilevoy 2020-11-30 23:56 ` [Tarantool-patches] [PATCH 07/10] test: rename fake libev methods to fakeev Vladislav Shpilevoy 2020-11-30 23:56 ` [Tarantool-patches] [PATCH 08/10] test: move fake libev code to fakeev.c/.h files Vladislav Shpilevoy 2020-11-30 23:56 ` [Tarantool-patches] [PATCH 09/10] test: factor out swim from fakeev.h/.c files Vladislav Shpilevoy 2020-12-01 13:42 ` Serge Petrenko [this message] 2020-12-01 22:33 ` [Tarantool-patches] [PATCH 00/10] Raft module, part 3 - fake network and libev for Raft and SWIM Vladislav Shpilevoy 2020-12-04 0:35 ` Alexander V. Tikhonov 2020-12-04 22:53 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6465ac03-2c3a-63e6-7392-df0543a072d0@tarantool.org \ --to=sergepetrenko@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 00/10] Raft module, part 3 - fake network and libev for Raft and SWIM' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox