From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 222DF45C304
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  1 Dec 2020 16:42:21 +0300 (MSK)
References: <cover.1606780408.git.v.shpilevoy@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <6465ac03-2c3a-63e6-7392-df0543a072d0@tarantool.org>
Date: Tue, 1 Dec 2020 16:42:20 +0300
MIME-Version: 1.0
In-Reply-To: <cover.1606780408.git.v.shpilevoy@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH 00/10] Raft module,
 part 3 - fake network and libev for Raft and SWIM
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org


01.12.2020 02:56, Vladislav Shpilevoy пишет:
> The patchset is a third part of Raft relocation to a new module for the sake of
> unit testing. This part extracts fake network and libev libraries from SWIM unit
> tests to a new library fakesys, which will be used by Raft.
>
> The patchset only moves the existing code. For the actual Raft tests it is
> likely I will add some new Raft-specific code, and probably will generalize
> something from swim_test_utils.h/.c.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5303-p3-fakesys
> Issue: https://github.com/tarantool/tarantool/issues/5303


Hi! Thanks for the patchset!

LGTM.


> Vladislav Shpilevoy (10):
>    test: stop using swim_transport.addr as in-param
>    test: factor out swim from libc emulation funcs
>    test: rename fake libc network methods to fakenet
>    test: move fake network code to fakenet.c/.h files
>    test: factor out swim from fakenet.c/.h files
>    fakesys: introduce fake system library
>    test: rename fake libev methods to fakeev
>    test: move fake libev code to fakeev.c/.h files
>    test: factor out swim from fakeev.h/.c files
>    fakesys: move fakeev to fakesys library
>
>   src/lib/CMakeLists.txt                        |   1 +
>   src/lib/fakesys/CMakeLists.txt                |   8 +
>   src/lib/fakesys/fakeev.c                      | 350 ++++++++++++
>   .../lib/fakesys/fakeev.h                      |  45 +-
>   src/lib/fakesys/fakenet.c                     | 502 ++++++++++++++++++
>   .../lib/fakesys/fakenet.h                     |  81 ++-
>   test/unit/CMakeLists.txt                      |   6 +-
>   test/unit/swim.c                              |   8 +-
>   test/unit/swim_errinj.c                       |   8 +-
>   test/unit/swim_test_ev.c                      | 319 +----------
>   test/unit/swim_test_transport.c               | 438 +--------------
>   test/unit/swim_test_utils.c                   |  30 +-
>   test/unit/swim_test_utils.h                   |   6 +-
>   13 files changed, 1003 insertions(+), 799 deletions(-)
>   create mode 100644 src/lib/fakesys/CMakeLists.txt
>   create mode 100644 src/lib/fakesys/fakeev.c
>   rename test/unit/swim_test_ev.h => src/lib/fakesys/fakeev.h (77%)
>   create mode 100644 src/lib/fakesys/fakenet.c
>   rename test/unit/swim_test_transport.h => src/lib/fakesys/fakenet.h (59%)
>
-- 
Serge Petrenko