From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 4/6] box: rework clear_synchro_queue to commit everything
Date: Thu, 24 Dec 2020 18:35:13 +0100 [thread overview]
Message-ID: <62b8a48a-f627-1155-246f-1493ea4e9459@tarantool.org> (raw)
In-Reply-To: <a6cb0d4f-4152-480c-8e5d-3de01be4c157@tarantool.org>
I've force pushed this diff:
====================
@@ -98,7 +98,7 @@ box_raft_update_synchro_queue(struct raft *raft)
uint32_t errcode = 0;
do {
rc = box_clear_synchro_queue(false);
- if (rc) {
+ if (rc != 0) {
struct error *err = diag_last_error(diag_get());
errcode = box_error_code(err);
diag_log();
====================
The patchset looks good, but the test hangs if I run it a lot of times
in parallel. I tried 132 times and after some number of runs all the
workers hung.
Couldn't find the reason right away.
next prev parent reply other threads:[~2020-12-24 17:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 11:59 [Tarantool-patches] [PATCH v2 0/6] make clear_synchro_queue " Serge Petrenko
2020-12-23 11:59 ` [Tarantool-patches] [PATCH v2 1/6] box: add a single execution guard to clear_synchro_queue Serge Petrenko
2020-12-23 11:59 ` [Tarantool-patches] [PATCH v2 2/6] relay: introduce on_status_update trigger Serge Petrenko
2020-12-23 17:25 ` Vladislav Shpilevoy
2020-12-24 16:11 ` Serge Petrenko
2020-12-23 11:59 ` [Tarantool-patches] [PATCH v2 3/6] txn_limbo: introduce txn_limbo_last_synchro_entry method Serge Petrenko
2020-12-23 17:25 ` Vladislav Shpilevoy
2020-12-24 16:13 ` Serge Petrenko
2020-12-23 11:59 ` [Tarantool-patches] [PATCH v2 4/6] box: rework clear_synchro_queue to commit everything Serge Petrenko
2020-12-23 17:28 ` Vladislav Shpilevoy
2020-12-24 16:12 ` Serge Petrenko
2020-12-24 17:35 ` Vladislav Shpilevoy [this message]
2020-12-24 21:02 ` Serge Petrenko
2020-12-23 11:59 ` [Tarantool-patches] [PATCH v2 5/6] test: fix replication/election_qsync_stress test Serge Petrenko
2020-12-23 11:59 ` [Tarantool-patches] [PATCH v2 6/6] txn_limbo: ignore CONFIRM/ROLLBACK for a foreign master Serge Petrenko
2020-12-23 17:28 ` Vladislav Shpilevoy
2020-12-24 16:13 ` Serge Petrenko
2020-12-25 10:04 ` [Tarantool-patches] [PATCH v2 0/6] make clear_synchro_queue commit everything Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62b8a48a-f627-1155-246f-1493ea4e9459@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 4/6] box: rework clear_synchro_queue to commit everything' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox