From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id E0A734765E0
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 24 Dec 2020 20:35:15 +0300 (MSK)
References: <cover.1608724238.git.sergepetrenko@tarantool.org>
 <3136023eb90fd3c6a10cb288466a9f3c8f9d2c01.1608724239.git.sergepetrenko@tarantool.org>
 <37c539ca-cdce-a4e9-5af9-3814b2c00131@tarantool.org>
 <a6cb0d4f-4152-480c-8e5d-3de01be4c157@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <62b8a48a-f627-1155-246f-1493ea4e9459@tarantool.org>
Date: Thu, 24 Dec 2020 18:35:13 +0100
MIME-Version: 1.0
In-Reply-To: <a6cb0d4f-4152-480c-8e5d-3de01be4c157@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 4/6] box: rework
 clear_synchro_queue to commit everything
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org

I've force pushed this diff:

====================
@@ -98,7 +98,7 @@ box_raft_update_synchro_queue(struct raft *raft)
 		uint32_t errcode = 0;
 		do {
 			rc = box_clear_synchro_queue(false);
-			if (rc) {
+			if (rc != 0) {
 				struct error *err = diag_last_error(diag_get());
 				errcode = box_error_code(err);
 				diag_log();
====================

The patchset looks good, but the test hangs if I run it a lot of times
in parallel. I tried 132 times and after some number of runs all the
workers hung.

Couldn't find the reason right away.