Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 2/6] relay: introduce on_status_update trigger
Date: Thu, 24 Dec 2020 19:11:58 +0300	[thread overview]
Message-ID: <0e83611c-0652-88a7-d290-f0d4fd9dbc17@tarantool.org> (raw)
In-Reply-To: <c0a46c67-4091-60e2-064e-08eb982b0045@tarantool.org>



23.12.2020 20:25, Vladislav Shpilevoy пишет:
> Thanks for the patch!
>
> On 23.12.2020 12:59, Serge Petrenko via Tarantool-patches wrote:
>> The trigger is fired from tx_status_update(), which is the notification
>> for tx that relay's vclock is updated.
>>
>> The trigger will be used to collect synchronous transactions quorum for
>> old leader's transactions.
> I meant the trigger could be global, not in relay. The main point of the
> proposal was not to touch relays almost anyhow. It would make things even
> simpler. I tried to implement it on your branch. See comments in the next
> emails, and 1 comment below, in case my proposal won't work somewhy.

Thanks for the review & for your suggestion!
Sorry I didn't understand your proposal at first. It looks good.
I've split your commit and amended this patch and the patch
"rework clear_synchro_queue".

>> Part of #5435
>> ---
>>   src/box/relay.cc | 12 ++++++++++++
>>   src/box/relay.h  |  4 ++++
>>   2 files changed, 16 insertions(+)
>>
>> diff --git a/src/box/relay.cc b/src/box/relay.cc
>> index e16ac5a6b..dbad8a680 100644
>> --- a/src/box/relay.cc
>> +++ b/src/box/relay.cc
>> @@ -201,6 +209,7 @@ relay_new(struct replica *replica)
>>   	diag_create(&relay->diag);
>>   	stailq_create(&relay->pending_gc);
>>   	relay->state = RELAY_OFF;
>> +	rlist_create(&relay->tx.on_status_update);
> You also need to add trigger_destroy() to relay_stop/relay_delete.
>
>>   	return relay;
>>   }

-- 
Serge Petrenko

  reply	other threads:[~2020-12-24 16:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23 11:59 [Tarantool-patches] [PATCH v2 0/6] make clear_synchro_queue commit everything Serge Petrenko
2020-12-23 11:59 ` [Tarantool-patches] [PATCH v2 1/6] box: add a single execution guard to clear_synchro_queue Serge Petrenko
2020-12-23 11:59 ` [Tarantool-patches] [PATCH v2 2/6] relay: introduce on_status_update trigger Serge Petrenko
2020-12-23 17:25   ` Vladislav Shpilevoy
2020-12-24 16:11     ` Serge Petrenko [this message]
2020-12-23 11:59 ` [Tarantool-patches] [PATCH v2 3/6] txn_limbo: introduce txn_limbo_last_synchro_entry method Serge Petrenko
2020-12-23 17:25   ` Vladislav Shpilevoy
2020-12-24 16:13     ` Serge Petrenko
2020-12-23 11:59 ` [Tarantool-patches] [PATCH v2 4/6] box: rework clear_synchro_queue to commit everything Serge Petrenko
2020-12-23 17:28   ` Vladislav Shpilevoy
2020-12-24 16:12     ` Serge Petrenko
2020-12-24 17:35       ` Vladislav Shpilevoy
2020-12-24 21:02         ` Serge Petrenko
2020-12-23 11:59 ` [Tarantool-patches] [PATCH v2 5/6] test: fix replication/election_qsync_stress test Serge Petrenko
2020-12-23 11:59 ` [Tarantool-patches] [PATCH v2 6/6] txn_limbo: ignore CONFIRM/ROLLBACK for a foreign master Serge Petrenko
2020-12-23 17:28   ` Vladislav Shpilevoy
2020-12-24 16:13     ` Serge Petrenko
2020-12-25 10:04 ` [Tarantool-patches] [PATCH v2 0/6] make clear_synchro_queue commit everything Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e83611c-0652-88a7-d290-f0d4fd9dbc17@tarantool.org \
    --to=sergepetrenko@tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v2 2/6] relay: introduce on_status_update trigger' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox