From: Leonid Vasiliev <lvasiliev@tarantool.org>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org,
v.shpilevoy@tarantool.org
Cc: Sergey Bronnikov <estetus@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v3 0/5] Support Python 3 in tests and PEPify source code
Date: Thu, 24 Dec 2020 02:42:23 +0300 [thread overview]
Message-ID: <56c9f21c-a711-adc1-e238-e83b798f0d29@tarantool.org> (raw)
In-Reply-To: <cover.1608726409.git.estetus@gmail.com>
Hi! Thank you for the patchset.
LGTM.
On 23.12.2020 15:36, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <estetus@gmail.com>
>
> Changes v3:
> - added patch with migration iteritems() to items()
> - revert changes that updates .result files
> - rework patch with bytes strings
>
> Changes v2:
> - make using quotes with strings consistent
> - remove dead code
> - remove empty prints
> - added make target for running flake8
> - added flake8 config
> - added job to run flake8 on Gitlab CI
>
> Changes v1:
> - convert print statements to functions
> - use "format()" instead of "%" everywhere
>
> Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/233768577
> Branch: https://github.com/tarantool/tarantool/tree/ligurio/gh-5538-support-python3
> Issue: https://github.com/tarantool/tarantool/issues/5538
>
> Sergey Bronnikov (5):
> test: convert print to function and make quotes use consistent
> test: make dict.items() compatible with Python 3.x
> test: make strings compatible with Python 3
> test: get rid of iteritems()
> test: remove dead code in Python tests end extra newlines
>
> test/app-tap/httpd.py | 44 ++---
> test/box-py/args.test.py | 12 +-
> test/box-py/bad_trigger.test.py | 16 +-
> test/box-py/bootstrap.test.py | 16 +-
> test/box-py/call.test.py | 80 ++++----
> test/box-py/iproto.test.py | 239 ++++++++++++-----------
> test/box-py/print.test.py | 25 +--
> test/box-py/snapshot.test.py | 19 +-
> test/long_run-py/finalizers.test.py | 10 +-
> test/replication-py/cluster.test.py | 217 ++++++++++----------
> test/replication-py/conflict.test.py | 55 +++---
> test/replication-py/init_storage.test.py | 58 +++---
> test/replication-py/multi.test.py | 78 ++++----
> test/replication-py/swap.test.py | 55 +++---
> test/xlog-py/big_lsn.test.py | 4 +-
> test/xlog-py/dup_key.test.py | 23 ++-
> test/xlog-py/empty.test.py | 4 +-
> test/xlog-py/lsn_gap.test.py | 11 +-
> test/xlog-py/misc.test.py | 26 +--
> test/xlog-py/missing.test.py | 10 +-
> 20 files changed, 518 insertions(+), 484 deletions(-)
>
next prev parent reply other threads:[~2020-12-23 23:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 12:36 sergeyb
2020-12-23 12:36 ` [Tarantool-patches] [PATCH v3 1/5] test: convert print to function and make quotes use consistent sergeyb
2020-12-23 15:39 ` Vladislav Shpilevoy
2020-12-24 10:50 ` Sergey Bronnikov
2020-12-23 12:36 ` [Tarantool-patches] [PATCH v3 2/5] test: make dict.items() compatible with Python 3.x sergeyb
2020-12-23 12:36 ` [Tarantool-patches] [PATCH v3 3/5] test: make strings compatible with Python 3 sergeyb
2020-12-23 15:40 ` Vladislav Shpilevoy
2020-12-24 11:03 ` Sergey Bronnikov
2020-12-23 12:36 ` [Tarantool-patches] [PATCH v3 4/5] test: get rid of iteritems() sergeyb
2020-12-23 12:36 ` [Tarantool-patches] [PATCH v3 5/5] test: remove dead code in Python tests end extra newlines sergeyb
2020-12-23 23:42 ` Leonid Vasiliev [this message]
2020-12-24 16:05 ` [Tarantool-patches] [PATCH v3 0/5] Support Python 3 in tests and PEPify source code Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56c9f21c-a711-adc1-e238-e83b798f0d29@tarantool.org \
--to=lvasiliev@tarantool.org \
--cc=estetus@gmail.com \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 0/5] Support Python 3 in tests and PEPify source code' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox