From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvasiliev@tarantool.org>
Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 713FB4765E0
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 24 Dec 2020 02:42:29 +0300 (MSK)
References: <cover.1608726409.git.estetus@gmail.com>
From: Leonid Vasiliev <lvasiliev@tarantool.org>
Message-ID: <56c9f21c-a711-adc1-e238-e83b798f0d29@tarantool.org>
Date: Thu, 24 Dec 2020 02:42:23 +0300
MIME-Version: 1.0
In-Reply-To: <cover.1608726409.git.estetus@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 0/5] Support Python 3 in tests
	and PEPify source code
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Cc: Sergey Bronnikov <estetus@gmail.com>

Hi! Thank you for the patchset.
LGTM.

On 23.12.2020 15:36, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <estetus@gmail.com>
> 
> Changes v3:
> - added patch with migration iteritems() to items()
> - revert changes that updates .result files
> - rework patch with bytes strings
> 
> Changes v2:
> - make using quotes with strings consistent
> - remove dead code
> - remove empty prints
> - added make target for running flake8
> - added flake8 config
> - added job to run flake8 on Gitlab CI
> 
> Changes v1:
> - convert print statements to functions
> - use "format()" instead of "%" everywhere
> 
> Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/233768577
> Branch: https://github.com/tarantool/tarantool/tree/ligurio/gh-5538-support-python3
> Issue: https://github.com/tarantool/tarantool/issues/5538
> 
> Sergey Bronnikov (5):
>    test: convert print to function and make quotes use consistent
>    test: make dict.items() compatible with Python 3.x
>    test: make strings compatible with Python 3
>    test: get rid of iteritems()
>    test: remove dead code in Python tests end extra newlines
> 
>   test/app-tap/httpd.py                    |  44 ++---
>   test/box-py/args.test.py                 |  12 +-
>   test/box-py/bad_trigger.test.py          |  16 +-
>   test/box-py/bootstrap.test.py            |  16 +-
>   test/box-py/call.test.py                 |  80 ++++----
>   test/box-py/iproto.test.py               | 239 ++++++++++++-----------
>   test/box-py/print.test.py                |  25 +--
>   test/box-py/snapshot.test.py             |  19 +-
>   test/long_run-py/finalizers.test.py      |  10 +-
>   test/replication-py/cluster.test.py      | 217 ++++++++++----------
>   test/replication-py/conflict.test.py     |  55 +++---
>   test/replication-py/init_storage.test.py |  58 +++---
>   test/replication-py/multi.test.py        |  78 ++++----
>   test/replication-py/swap.test.py         |  55 +++---
>   test/xlog-py/big_lsn.test.py             |   4 +-
>   test/xlog-py/dup_key.test.py             |  23 ++-
>   test/xlog-py/empty.test.py               |   4 +-
>   test/xlog-py/lsn_gap.test.py             |  11 +-
>   test/xlog-py/misc.test.py                |  26 +--
>   test/xlog-py/missing.test.py             |  10 +-
>   20 files changed, 518 insertions(+), 484 deletions(-)
>