Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
	tarantool-patches@dev.tarantool.org, lvasiliev@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 1/5] test: convert print to function and make quotes use consistent
Date: Thu, 24 Dec 2020 13:50:41 +0300	[thread overview]
Message-ID: <61dda0a6-29db-1741-5bbf-1ea7524630d6@tarantool.org> (raw)
In-Reply-To: <f96f5493-2f5e-54f9-94d0-8aaa22a3f407@tarantool.org>

Thanks for review!

On 23.12.2020 18:39, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
>
>> diff --git a/test/replication-py/swap.test.py b/test/replication-py/swap.test.py
>> index 98eeeea6d..b162ae241 100644
>> --- a/test/replication-py/swap.test.py
>> +++ b/test/replication-py/swap.test.py
>> @@ -7,26 +9,26 @@ import yaml
>>   REPEAT = 20
>>   ID_BEGIN = 0
>>   ID_STEP = 5
>> -LOGIN = 'test'
>> -PASSWORD = 'pass123456'
>> +LOGIN = "test"
>> +PASSWORD = "pass123456"
>>   
>> -engines = ['memtx', 'vinyl']
>> +engines = ["memtx", "vinyl"]
>>   
>>   def insert_tuples(_server, begin, end, msg = "tuple"):
>>       for engine in engines:
>>           for i in range(begin, end):
>> -            print 'box.space.%s:insert{%d, "%s %d"}' % (engine, i, msg, i)
>> -            print '-'
>> +            print('box.space.{}:insert{{{}, "{} {}"}}'.format(engine, i, msg, i))
> Oh, noooo! There is still ' instead of " !!!

Fixed and force-pushed.

--- a/test/replication-py/swap.test.py
+++ b/test/replication-py/swap.test.py
@@ -17,7 +17,7 @@ engines = ["memtx", "vinyl"]
  def insert_tuples(_server, begin, end, msg = "tuple"):
      for engine in engines:
          for i in range(begin, end):
-            print('box.space.{}:insert{{{}, "{} {}"}}'.format(engine, 
i, msg, i))
+            print("box.space.{}:insert{{{}, \"{} {}\"}}".format(engine, 
i, msg, i))
              print("-")
              space = _server.iproto.py_con.space(engine)
              print(space.insert((i, "{} {}".format(msg, i))))

  reply	other threads:[~2020-12-24 10:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23 12:36 [Tarantool-patches] [PATCH v3 0/5] Support Python 3 in tests and PEPify source code sergeyb
2020-12-23 12:36 ` [Tarantool-patches] [PATCH v3 1/5] test: convert print to function and make quotes use consistent sergeyb
2020-12-23 15:39   ` Vladislav Shpilevoy
2020-12-24 10:50     ` Sergey Bronnikov [this message]
2020-12-23 12:36 ` [Tarantool-patches] [PATCH v3 2/5] test: make dict.items() compatible with Python 3.x sergeyb
2020-12-23 12:36 ` [Tarantool-patches] [PATCH v3 3/5] test: make strings compatible with Python 3 sergeyb
2020-12-23 15:40   ` Vladislav Shpilevoy
2020-12-24 11:03     ` Sergey Bronnikov
2020-12-23 12:36 ` [Tarantool-patches] [PATCH v3 4/5] test: get rid of iteritems() sergeyb
2020-12-23 12:36 ` [Tarantool-patches] [PATCH v3 5/5] test: remove dead code in Python tests end extra newlines sergeyb
2020-12-23 23:42 ` [Tarantool-patches] [PATCH v3 0/5] Support Python 3 in tests and PEPify source code Leonid Vasiliev
2020-12-24 16:05 ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61dda0a6-29db-1741-5bbf-1ea7524630d6@tarantool.org \
    --to=sergeyb@tarantool.org \
    --cc=lvasiliev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3 1/5] test: convert print to function and make quotes use consistent' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox