Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org,
	lvasiliev@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v7 3/3] luacheck: fix warnings in test/box-tap
Date: Mon, 11 Jan 2021 18:52:51 +0100	[thread overview]
Message-ID: <4f8d3525-ad8d-5c2a-429d-b87dc8ceb443@tarantool.org> (raw)
In-Reply-To: <d063860ffaaf2667c9066902bc871cf4b20fc619.1608647958.git.estetus@gmail.com>

Thanks for the patch!

> diff --git a/.luacheckrc b/.luacheckrc
> index 52625bb35..b7f9abb45 100644
> --- a/.luacheckrc
> +++ b/.luacheckrc
> @@ -157,3 +156,23 @@ files["test/box/lua/fifo.lua"] = {
>  files["test/box/lua/identifier.lua"] = {
>       globals = {"run_test"}
>  }
> +files["test/box-tap/session.test.lua"] = {
> +    globals = {
> +        "active_connections",

This can be declared 'local'.

====================
@@ -70,6 +70,7 @@ session.on_disconnect(nil, fail)
 
 -- check how connect/disconnect triggers work
 local peer_name = "peer_name"
+local active_connections = 0
 local function inc() active_connections = active_connections + 1 end
 local function dec() active_connections = active_connections - 1 end
 local function peer() peer_name = box.session.peer() end
@@ -77,7 +78,6 @@ local net = { box = require('net.box') }
 test:is(type(session.on_connect(inc)), "function", "type of trigger inc on_connect")
 test:is(type(session.on_disconnect(dec)), "function", "type of trigger dec on_disconnect")
 test:is(type(session.on_disconnect(peer)), "function", "type of trigger peer on_disconnect")
-active_connections = 0
 local c = net.box.connect(HOST, PORT)
====================

  reply	other threads:[~2021-01-11 17:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22 14:54 [Tarantool-patches] [PATCH v7 0/3] Fix luacheck warnings in test/box-tap, test/box and test/box-py sergeyb
2020-12-22 14:54 ` [Tarantool-patches] [PATCH 1/3] luacheck: fix warnings in test/box sergeyb
2021-01-11 17:52   ` Vladislav Shpilevoy via Tarantool-patches
2021-01-12 15:26     ` Sergey Bronnikov via Tarantool-patches
2021-01-13  7:58       ` Sergey Bronnikov via Tarantool-patches
2021-01-13 16:38       ` Vladislav Shpilevoy via Tarantool-patches
2021-01-14  7:49         ` Sergey Bronnikov via Tarantool-patches
2020-12-22 14:54 ` [Tarantool-patches] [PATCH v7 2/3] luacheck: fix warnings in test/box-py sergeyb
2020-12-22 14:54 ` [Tarantool-patches] [PATCH v7 3/3] luacheck: fix warnings in test/box-tap sergeyb
2021-01-11 17:52   ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-01-12 13:59     ` Sergey Bronnikov via Tarantool-patches
2021-01-12 14:52       ` Vladislav Shpilevoy via Tarantool-patches
2021-01-12 15:21         ` Sergey Bronnikov via Tarantool-patches
2020-12-25 10:37 ` [Tarantool-patches] [PATCH v7 0/3] Fix luacheck warnings in test/box-tap, test/box and test/box-py Kirill Yukhin
2020-12-30 10:17   ` Kirill Yukhin
2020-12-30 12:27 ` Leonid Vasiliev
2021-01-14 21:34 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-15  9:48 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f8d3525-ad8d-5c2a-429d-b87dc8ceb443@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=lvasiliev@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v7 3/3] luacheck: fix warnings in test/box-tap' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox