From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B985F4C883; Mon, 11 Jan 2021 20:53:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B985F4C883 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610387603; bh=TfSVZOoY7PGySCxl/S4QPTGJHiDfz3mf7PwGIN1ohk0=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ATHiCzpeNtgU2Xl0u0p9Q8SQqLFjbMDBkumd3999ewlUOudTjFirptAMTr/JJiCHi /GWHJjVeS46bMPdKu3PgJNfR8bXxrba/jPa80e6U0kzAk3sI9OlRGAIIWXygTVDP3P sFqw3zs4yRwSRjirFuW6MTM9RyQHjnZjBKA2ADIA= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4AF5A4C889 for ; Mon, 11 Jan 2021 20:52:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4AF5A4C889 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1kz1N6-0004kf-Ds; Mon, 11 Jan 2021 20:52:52 +0300 To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org, lvasiliev@tarantool.org References: Message-ID: <4f8d3525-ad8d-5c2a-429d-b87dc8ceb443@tarantool.org> Date: Mon, 11 Jan 2021 18:52:51 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CD81CC0669AF3BE2AC14A0BAA29BC1501600894C459B0CD1B93B3BC2A6D64A8E0536CEB447DCBC6BD1C1ABA22156B6F8F6BE00556ACD475582 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D9C4478D0B876341EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D99F96657F58F1038638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC9FBEA1394F81B8B747D30B219B12C8F10835D1A8E59A1E12389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0B882963B8E9439758941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC8A0925CD2C14BB9D75ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4931B544F03EFBC4D57E5B2F3A2B87CD4C8C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0FECB2555BB02FD5A93B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A585E42DBD8C7024B13E35BFD1D69A8F680B9B1CD2C2138B72D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758F9E841AEAEC4F2C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3463DBE2ADA183F62FBB6C0413DFF7323C0355B8F7A2361E9E25C1706C7215BB5167B376739E7D5F3D1D7E09C32AA3244C6B985C9DDC2F628254E94617BB6327ADB018FE5BB746DCD1FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmz2Dv49v36ir9fUnAcA3uA== X-Mailru-Sender: 689FA8AB762F73937240DDB2502DDB70AC2E3E7DFFBBEBF6923C79955ACCAFFC3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v7 3/3] luacheck: fix warnings in test/box-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! > diff --git a/.luacheckrc b/.luacheckrc > index 52625bb35..b7f9abb45 100644 > --- a/.luacheckrc > +++ b/.luacheckrc > @@ -157,3 +156,23 @@ files["test/box/lua/fifo.lua"] = { > files["test/box/lua/identifier.lua"] = { > globals = {"run_test"} > } > +files["test/box-tap/session.test.lua"] = { > + globals = { > + "active_connections", This can be declared 'local'. ==================== @@ -70,6 +70,7 @@ session.on_disconnect(nil, fail) -- check how connect/disconnect triggers work local peer_name = "peer_name" +local active_connections = 0 local function inc() active_connections = active_connections + 1 end local function dec() active_connections = active_connections - 1 end local function peer() peer_name = box.session.peer() end @@ -77,7 +78,6 @@ local net = { box = require('net.box') } test:is(type(session.on_connect(inc)), "function", "type of trigger inc on_connect") test:is(type(session.on_disconnect(dec)), "function", "type of trigger dec on_disconnect") test:is(type(session.on_disconnect(peer)), "function", "type of trigger peer on_disconnect") -active_connections = 0 local c = net.box.connect(HOST, PORT) ====================