Re: [Tarantool-patches] [PATCH v7 0/3] Fix luacheck warnings in test/box-tap, test/box and test/box-py

[Leonid Vasiliev <lvasiliev@tarantool.org>]

Hi! Thank you for the patchset!
LGTM.

On 22.12.2020 17:54, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <estetus@gmail.com>
> 
> Changelog v7:
> - rebased to master branch and fixed new warnings
> - splitted a huge patch series for test/ to a separate issues and patches series
>    (other patches will follow)
> 
> Changelog v6:
> 
> - splitted patch in test/ for patches per sub-directory
> - adjusted supressions in .luacheckrc
> - fixed formatting issues in .luacheckrc
> - fixed warnings in test/vinyl/vinyl.lua and test/vinyl/large.lua
> - added commit with bumping luajit version
> - fixed warnings in test/app-tap/lua/serializer_test.lua
> 
> NOTE: most luacheck patches includes changes in .luacheckrc so branch with
> patches from this patch series includes uncommitted (but with one LGTM) patches
> for test/app and test/app-tap (ligurio/gh-5453-luacheck-warnings-test-app-tap).
> 
> 1. https://lists.tarantool.org/pipermail/tarantool-patches/2020-December/021385.html
> 
> Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/233332402
> GH branch: ligurio/gh-5455-luacheck-warnings-test-box
> GH issues:
>    - https://github.com/tarantool/tarantool/issues/5455
>    - https://github.com/tarantool/tarantool/issues/5456
>    - https://github.com/tarantool/tarantool/issues/5457
> 
> Sergey Bronnikov (3):
>    luacheck: fix warnings in test/box
>    luacheck: fix warnings in test/box-py
>    luacheck: fix warnings in test/box-tap
> 
>   .luacheckrc                                   | 80 ++++++++++++++++++-
>   test/box-py/box.lua                           |  2 +-
>   test/box-tap/auth.test.lua                    | 20 ++---
>   test/box-tap/cfg.test.lua                     | 34 ++++----
>   test/box-tap/cfgup.test.lua                   |  4 +-
>   test/box-tap/extended_error.test.lua          | 11 +--
>   test/box-tap/feedback_daemon.test.lua         |  8 +-
>   test/box-tap/gc.test.lua                      |  4 +-
>   test/box-tap/gh-4688-box-info-memory.test.lua |  2 +-
>   test/box-tap/on_schema_init.test.lua          |  4 +-
>   test/box-tap/schema_mt.test.lua               | 22 ++---
>   test/box-tap/session.storage.test.lua         | 10 +--
>   test/box-tap/session.test.lua                 | 56 ++++++-------
>   test/box-tap/trigger_atexit.test.lua          | 10 +--
>   test/box-tap/trigger_yield.test.lua           | 10 +--
>   test/box/box.lua                              |  4 +-
>   test/box/lua/bitset.lua                       |  7 +-
>   test/box/lua/cfg_bad_vinyl_dir.lua            |  2 +-
>   test/box/lua/cfg_rtree.lua                    |  2 +-
>   test/box/lua/cfg_test1.lua                    |  2 +-
>   test/box/lua/cfg_test2.lua                    |  2 +-
>   test/box/lua/cfg_test3.lua                    |  2 +-
>   test/box/lua/cfg_test4.lua                    |  2 +-
>   test/box/lua/cfg_test5.lua                    |  2 +-
>   test/box/lua/cfg_test6.lua                    |  2 +-
>   test/box/lua/cfg_test8.lua                    |  2 +-
>   test/box/lua/fifo.lua                         |  2 +-
>   test/box/lua/identifier.lua                   |  9 +--
>   test/box/lua/index_random_test.lua            |  2 +-
>   test/box/lua/txn_proxy.lua                    |  6 +-
>   test/box/lua/utils.lua                        | 10 +--
>   test/box/on_schema_init.lua                   |  8 +-
>   test/box/proxy.lua                            |  2 +-
>   test/box/tiny.lua                             |  2 +-
>   34 files changed, 202 insertions(+), 145 deletions(-)
>