From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org,
lvasiliev@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v7 2/3] luacheck: fix warnings in test/app
Date: Sun, 20 Dec 2020 14:59:39 +0100 [thread overview]
Message-ID: <4d0f40dd-3974-54d0-4986-f210774dc984@tarantool.org> (raw)
In-Reply-To: <234ebec733eb0931bb0394cee74eca42bfb6af3a.1608127545.git.sergeyb@tarantool.org>
Thanks for the patch!
> diff --git a/.luacheckrc b/.luacheckrc
> index ae96576ec..d9093a5eb 100644
> --- a/.luacheckrc
> +++ b/.luacheckrc
> @@ -109,3 +109,6 @@ files["test/app-tap/lua/require_mod.lua"] = {
> files["test/app-tap/string.test.lua"] = {
> globals = {"utf8"}
> }
> +files["test/app/lua/fiber.lua"] = {
> + globals = {"box_fiber_run_test"}
> +}
fiber.lua is used in one place, where it can be properly fixed
instead of ignored. fiber.lua can 'return box_fiber_run_test' in
the end instead of passing this function as a global variable.
next prev parent reply other threads:[~2020-12-20 13:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 15:59 [Tarantool-patches] [PATCH v7 0/3] Fix luacheck warnings in test/app-tap and test/app sergeyb
2020-12-16 16:00 ` [Tarantool-patches] [PATCH v7 1/3] luacheck: fix warnings in test/app-tap sergeyb
2020-12-20 13:59 ` Vladislav Shpilevoy
2020-12-21 10:02 ` Sergey Bronnikov
2020-12-16 16:00 ` [Tarantool-patches] [PATCH v7 2/3] luacheck: fix warnings in test/app sergeyb
2020-12-20 13:59 ` Vladislav Shpilevoy [this message]
2020-12-21 11:00 ` Sergey Bronnikov
2020-12-16 16:00 ` [Tarantool-patches] [PATCH v7 3/3] luacheck: remove unneeded comment sergeyb
2020-12-21 17:17 ` [Tarantool-patches] [PATCH v7 0/3] Fix luacheck warnings in test/app-tap and test/app Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d0f40dd-3974-54d0-4986-f210774dc984@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=lvasiliev@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v7 2/3] luacheck: fix warnings in test/app' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox