From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 05A7145C305
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 20 Dec 2020 16:59:40 +0300 (MSK)
References: <cover.1608127545.git.sergeyb@tarantool.org>
 <234ebec733eb0931bb0394cee74eca42bfb6af3a.1608127545.git.sergeyb@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <4d0f40dd-3974-54d0-4986-f210774dc984@tarantool.org>
Date: Sun, 20 Dec 2020 14:59:39 +0100
MIME-Version: 1.0
In-Reply-To: <234ebec733eb0931bb0394cee74eca42bfb6af3a.1608127545.git.sergeyb@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v7 2/3] luacheck: fix warnings in
 test/app
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org, lvasiliev@tarantool.org

Thanks for the patch!

> diff --git a/.luacheckrc b/.luacheckrc
> index ae96576ec..d9093a5eb 100644
> --- a/.luacheckrc
> +++ b/.luacheckrc
> @@ -109,3 +109,6 @@ files["test/app-tap/lua/require_mod.lua"] = {
>  files["test/app-tap/string.test.lua"] = {
>      globals = {"utf8"}
>  }
> +files["test/app/lua/fiber.lua"] = {
> +    globals = {"box_fiber_run_test"}
> +}

fiber.lua is used in one place, where it can be properly fixed
instead of ignored. fiber.lua can 'return box_fiber_run_test' in
the end instead of passing this function as a global variable.