From: sergeyb@tarantool.org To: tarantool-patches@dev.tarantool.org, lvasiliev@tarantool.org, v.shpilevoy@tarantool.org Subject: [Tarantool-patches] [PATCH v7 0/3] Fix luacheck warnings in test/app-tap and test/app Date: Wed, 16 Dec 2020 18:59:58 +0300 [thread overview] Message-ID: <cover.1608127545.git.sergeyb@tarantool.org> (raw) From: Sergey Bronnikov <sergeyb@tarantool.org> Changelog v7: - reverted changes with shadowing - reverted changes with redefinitions - rebased to master branch - splitted a huge patch series for test/ to a separate issues and patches series (other patches will follow) Changelog v6: - splitted patch in test/ for patches per sub-directory - adjusted supressions in .luacheckrc - fixed formatting issues in .luacheckrc - fixed warnings in test/vinyl/vinyl.lua and test/vinyl/large.lua - added commit with bumping luajit version - fixed warnings in test/app-tap/lua/serializer_test.lua NOTE: patch v6 for app-tap sent in [1] got LGTM from Igor Munkin in [2], but later Alexander Turenko initiated discussion [3] and we decided verbally to revert some changes in all patches. 1. https://lists.tarantool.org/pipermail/tarantool-patches/2020-May/017237.html 2. https://lists.tarantool.org/pipermail/tarantool-patches/2020-June/017301.html 3. https://lists.tarantool.org/pipermail/tarantool-patches/2020-June/017312.html GH issues: - https://github.com/tarantool/tarantool/issues/5453 - https://github.com/tarantool/tarantool/issues/5454 GitLab: https://gitlab.com/tarantool/tarantool/-/pipelines/230796285 Branch: ligurio/gh-5453-luacheck-warnings-test-app-tap Sergey Bronnikov (3): luacheck: fix warnings in test/app-tap luacheck: fix warnings in test/app luacheck: remove unneeded comment .luacheckrc | 15 ++++- test/app-tap/cfg.test.lua | 2 +- test/app-tap/clock.test.lua | 4 +- test/app-tap/console.test.lua | 12 ++-- test/app-tap/csv.test.lua | 56 +++++++++---------- test/app-tap/fail_main.test.lua | 4 +- .../gh-4761-json-per-call-options.test.lua | 4 +- test/app-tap/gh-5013-fiber-cancel.test.lua | 2 +- .../gh-5130-panic-on-invalid-log.test.lua | 4 +- test/app-tap/http_client.test.lua | 25 +++------ test/app-tap/iconv.test.lua | 4 +- test/app-tap/init_script.test.lua | 16 +++--- test/app-tap/inspector.test.lua | 5 +- test/app-tap/json.test.lua | 1 - test/app-tap/logger.test.lua | 12 ++-- test/app-tap/lua/serializer_test.lua | 28 +++------- test/app-tap/module_api.test.lua | 13 ++--- test/app-tap/msgpackffi.test.lua | 3 +- test/app-tap/pcall.test.lua | 2 +- test/app-tap/snapshot.test.lua | 15 +++-- test/app-tap/string.test.lua | 30 +++++----- test/app-tap/tap.test.lua | 4 +- test/app-tap/tarantoolctl.test.lua | 46 ++++++--------- test/app-tap/trigger.test.lua | 8 +-- test/app-tap/yaml.test.lua | 14 ++--- test/app-tap/yield-in-gc-finalizer.test.lua | 3 +- 26 files changed, 150 insertions(+), 182 deletions(-) -- 2.25.1
next reply other threads:[~2020-12-16 16:01 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-16 15:59 sergeyb [this message] 2020-12-16 16:00 ` [Tarantool-patches] [PATCH v7 1/3] luacheck: fix warnings in test/app-tap sergeyb 2020-12-20 13:59 ` Vladislav Shpilevoy 2020-12-21 10:02 ` Sergey Bronnikov 2020-12-16 16:00 ` [Tarantool-patches] [PATCH v7 2/3] luacheck: fix warnings in test/app sergeyb 2020-12-20 13:59 ` Vladislav Shpilevoy 2020-12-21 11:00 ` Sergey Bronnikov 2020-12-16 16:00 ` [Tarantool-patches] [PATCH v7 3/3] luacheck: remove unneeded comment sergeyb 2020-12-21 17:17 ` [Tarantool-patches] [PATCH v7 0/3] Fix luacheck warnings in test/app-tap and test/app Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1608127545.git.sergeyb@tarantool.org \ --to=sergeyb@tarantool.org \ --cc=lvasiliev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v7 0/3] Fix luacheck warnings in test/app-tap and test/app' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox