Re: [Tarantool-patches] [PATCH luajit 2/3] OSX/iOS: Handle iOS simulator and ARM64 Macs.

[Sergey Ostanevich via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 3082 bytes --]

Thanks for the patch, LGTM.

Sergos

> On 11 May 2021, at 14:03, Igor Munkin <imun@tarantool.org> wrote:
> 
> Sergey,
> 
> Thanks for your review! I've made some minor changes to associate this
> patch with the proper issue[1]. Diff is below:
> 
> ================================================================================
> 
> diff --git a/test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua b/test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua
> similarity index 82%
> rename from test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua
> rename to test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua
> index b23dd712..7110e351 100644
> --- a/test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua
> +++ b/test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua
> @@ -1,6 +1,6 @@
> local tap = require('tap')
> 
> -local test = tap.test('gh-5983-jit-library-smoke-tests')
> +local test = tap.test('gh-6065-jit-library-smoke-tests')
> test:plan(1)
> 
> -- Just check whether LuaJIT is built with JIT support. Otherwise,
> 
> ================================================================================
> 
> On 11.05.21, Sergey Kaplun wrote:
>> 
>> Hi, Igor!
>> 
>> Thanks for the patch! LGTM!
> 
> Added your tag:
> | Reviewed-by: Sergey Kaplun <skaplun@tarantool.org <mailto:skaplun@tarantool.org>>
> 
>> 
>> On 11.05.21, Igor Munkin wrote:
>>> From: Mike Pall <mike>
>> 
>> Side note: I am a little bit confused by this line (I thought that it is
>> a part of the commit message). May be it is better to drop it or to
>> write like:
> 
> Hm, this looks like a common practice if *you* send *someone's* patch to
> be applied. IIRC, git am takes the entry below as commit author.
> 
>> 
>> | # From: Mike Pall <mike>
>> 
>>> 
>>> (cherry picked from commit 2e2fb8f6b5118e1a7996b76600c6ee98bfd5f203)
>>> 
>>> After Apple released Macs working on ARM64, the previous recipe in
>>> lj_arch.h for detecting various Apple platforms is not valid anymore.
>>> Fortunately, there is a system header (i.e. TargetConditionals.h),
>>> provided by SDK with the proper defines to be set. Starting from this
>>> patch, LuaJIT identifies Apple hosts via this header.
>>> 
>>> Since testing machinery assumes that LuaJIT is built with JIT support
>>> being enabled unconditionally, a smoke test for it is also added
>>> alongside with this patch.
>>> 
>>> Igor Munkin:
>>> * added the description and the test for the problem
>>> * backported the original patch to tarantool/luajit repo
>>> 
> 
> Mentioned the issue[1]:
> | Resolves tarantool/tarantool#6065
> 
>>> Part of tarantool/tarantool#5629
>>> Relates to tarantool/tarantool#5983
>>> 
>>> Signed-off-by: Igor Munkin <imun@tarantool.org <mailto:imun@tarantool.org>>
>>> ---
>> 
>> <snipped>
>> 
>> 
>> -- 
>> Best regards,
>> Sergey Kaplun
> 
> [1]: https://github.com/tarantool/tarantool/issues/6065 <https://github.com/tarantool/tarantool/issues/6065>
> 
> -- 
> Best regards,
> IM


[-- Attachment #2: Type: text/html, Size: 32648 bytes --]