Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Ostanevich via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] OSX/iOS: Handle iOS simulator and ARM64 Macs.
Date: Fri, 14 May 2021 14:36:36 +0300
Message-ID: <456180FD-E66E-4DC3-810A-1411ABF268E3@tarantool.org> (raw)
In-Reply-To: <20210511110305.GC3944@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 3082 bytes --]

Thanks for the patch, LGTM.

Sergos

> On 11 May 2021, at 14:03, Igor Munkin <imun@tarantool.org> wrote:
> 
> Sergey,
> 
> Thanks for your review! I've made some minor changes to associate this
> patch with the proper issue[1]. Diff is below:
> 
> ================================================================================
> 
> diff --git a/test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua b/test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua
> similarity index 82%
> rename from test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua
> rename to test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua
> index b23dd712..7110e351 100644
> --- a/test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua
> +++ b/test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua
> @@ -1,6 +1,6 @@
> local tap = require('tap')
> 
> -local test = tap.test('gh-5983-jit-library-smoke-tests')
> +local test = tap.test('gh-6065-jit-library-smoke-tests')
> test:plan(1)
> 
> -- Just check whether LuaJIT is built with JIT support. Otherwise,
> 
> ================================================================================
> 
> On 11.05.21, Sergey Kaplun wrote:
>> 
>> Hi, Igor!
>> 
>> Thanks for the patch! LGTM!
> 
> Added your tag:
> | Reviewed-by: Sergey Kaplun <skaplun@tarantool.org <mailto:skaplun@tarantool.org>>
> 
>> 
>> On 11.05.21, Igor Munkin wrote:
>>> From: Mike Pall <mike>
>> 
>> Side note: I am a little bit confused by this line (I thought that it is
>> a part of the commit message). May be it is better to drop it or to
>> write like:
> 
> Hm, this looks like a common practice if *you* send *someone's* patch to
> be applied. IIRC, git am takes the entry below as commit author.
> 
>> 
>> | # From: Mike Pall <mike>
>> 
>>> 
>>> (cherry picked from commit 2e2fb8f6b5118e1a7996b76600c6ee98bfd5f203)
>>> 
>>> After Apple released Macs working on ARM64, the previous recipe in
>>> lj_arch.h for detecting various Apple platforms is not valid anymore.
>>> Fortunately, there is a system header (i.e. TargetConditionals.h),
>>> provided by SDK with the proper defines to be set. Starting from this
>>> patch, LuaJIT identifies Apple hosts via this header.
>>> 
>>> Since testing machinery assumes that LuaJIT is built with JIT support
>>> being enabled unconditionally, a smoke test for it is also added
>>> alongside with this patch.
>>> 
>>> Igor Munkin:
>>> * added the description and the test for the problem
>>> * backported the original patch to tarantool/luajit repo
>>> 
> 
> Mentioned the issue[1]:
> | Resolves tarantool/tarantool#6065
> 
>>> Part of tarantool/tarantool#5629
>>> Relates to tarantool/tarantool#5983
>>> 
>>> Signed-off-by: Igor Munkin <imun@tarantool.org <mailto:imun@tarantool.org>>
>>> ---
>> 
>> <snipped>
>> 
>> 
>> -- 
>> Best regards,
>> Sergey Kaplun
> 
> [1]: https://github.com/tarantool/tarantool/issues/6065 <https://github.com/tarantool/tarantool/issues/6065>
> 
> -- 
> Best regards,
> IM


[-- Attachment #2: Type: text/html, Size: 32648 bytes --]

  reply	other threads:[~2021-05-14 11:36 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 22:09 [Tarantool-patches] [PATCH luajit 0/3] Basic fixes for LuaJIT on " Igor Munkin via Tarantool-patches
2021-05-10 22:09 ` [Tarantool-patches] [PATCH luajit 1/3] build: pass sysroot to MacOS SDK Igor Munkin via Tarantool-patches
2021-05-11  9:49   ` Sergey Kaplun via Tarantool-patches
2021-05-12 21:55     ` Igor Munkin via Tarantool-patches
2021-05-14 16:07       ` Sergey Kaplun via Tarantool-patches
2021-05-17 17:21         ` Igor Munkin via Tarantool-patches
2021-05-18  5:50           ` Sergey Kaplun via Tarantool-patches
2021-05-18 18:47             ` Igor Munkin via Tarantool-patches
2021-05-19 11:38               ` Igor Munkin via Tarantool-patches
2021-05-19 12:40                 ` Sergey Ostanevich via Tarantool-patches
2021-05-19 13:23                   ` Igor Munkin via Tarantool-patches
2021-05-19 16:06                     ` Sergey Kaplun via Tarantool-patches
2021-05-10 22:09 ` [Tarantool-patches] [PATCH luajit 2/3] OSX/iOS: Handle iOS simulator and ARM64 Macs Igor Munkin via Tarantool-patches
2021-05-11 11:02   ` Sergey Kaplun via Tarantool-patches
2021-05-11 11:03     ` Igor Munkin via Tarantool-patches
2021-05-14 11:36       ` Sergey Ostanevich via Tarantool-patches [this message]
2021-05-14 11:27         ` Igor Munkin via Tarantool-patches
2021-05-10 22:09 ` [Tarantool-patches] [PATCH luajit 3/3] FFI/ARM64/OSX: Fix vararg call handling Igor Munkin via Tarantool-patches
2021-05-11 11:07   ` Sergey Kaplun via Tarantool-patches
2021-05-11 11:31     ` Igor Munkin via Tarantool-patches
2021-05-12 16:11       ` Sergey Ostanevich via Tarantool-patches
2021-05-12 21:59         ` Igor Munkin via Tarantool-patches
2021-05-13  9:50           ` Sergey Ostanevich via Tarantool-patches
2021-05-13 10:44             ` Igor Munkin via Tarantool-patches
2021-05-14 10:10               ` Sergey Ostanevich via Tarantool-patches
2021-05-14 10:31                 ` Igor Munkin via Tarantool-patches
2021-05-19 15:38 ` [Tarantool-patches] [PATCH luajit 0/3] Basic fixes for LuaJIT on ARM64 Macs Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456180FD-E66E-4DC3-810A-1411ABF268E3@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=sergos@tarantool.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Tarantool development patches archive

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lists.tarantool.org/tarantool-patches/0 tarantool-patches/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 tarantool-patches tarantool-patches/ https://lists.tarantool.org/tarantool-patches \
		tarantool-patches@dev.tarantool.org.
	public-inbox-index tarantool-patches

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git