From: Sergey Ostanevich via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] FFI/ARM64/OSX: Fix vararg call handling.
Date: Wed, 12 May 2021 19:11:31 +0300 [thread overview]
Message-ID: <2922F816-67DD-45D0-8F97-6CA2EB36F66E@tarantool.org> (raw)
In-Reply-To: <20210511113115.GD3944@tarantool.org>
Hi!
I can’t get this then
src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_IOS
How’s that survived in 2.1 branch?
regards,
Sergos
> On 11 May 2021, at 14:31, Igor Munkin <imun@tarantool.org> wrote:
>
> Sergey,
>
> Thanks for your review!
>
> On 11.05.21, Sergey Kaplun wrote:
>> Hi, Igor!
>>
>> Thanks for the patch!
>> LGTM!
>
> Added your tag:
> | Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>
>
> Also mentioned the issue[1]:
> | Resolves tarantool/tarantool#6066
>
>>
>> --
>> Best regards,
>> Sergey Kaplun
>
> [1]: https://github.com/tarantool/tarantool/issues/6066
>
> --
> Best regards,
> IM
next prev parent reply other threads:[~2021-05-12 16:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 22:09 [Tarantool-patches] [PATCH luajit 0/3] Basic fixes for LuaJIT on ARM64 Macs Igor Munkin via Tarantool-patches
2021-05-10 22:09 ` [Tarantool-patches] [PATCH luajit 1/3] build: pass sysroot to MacOS SDK Igor Munkin via Tarantool-patches
2021-05-11 9:49 ` Sergey Kaplun via Tarantool-patches
2021-05-12 21:55 ` Igor Munkin via Tarantool-patches
2021-05-14 16:07 ` Sergey Kaplun via Tarantool-patches
2021-05-17 17:21 ` Igor Munkin via Tarantool-patches
2021-05-18 5:50 ` Sergey Kaplun via Tarantool-patches
2021-05-18 18:47 ` Igor Munkin via Tarantool-patches
2021-05-19 11:38 ` Igor Munkin via Tarantool-patches
2021-05-19 12:40 ` Sergey Ostanevich via Tarantool-patches
2021-05-19 13:23 ` Igor Munkin via Tarantool-patches
2021-05-19 16:06 ` Sergey Kaplun via Tarantool-patches
2021-05-10 22:09 ` [Tarantool-patches] [PATCH luajit 2/3] OSX/iOS: Handle iOS simulator and ARM64 Macs Igor Munkin via Tarantool-patches
2021-05-11 11:02 ` Sergey Kaplun via Tarantool-patches
2021-05-11 11:03 ` Igor Munkin via Tarantool-patches
2021-05-14 11:36 ` Sergey Ostanevich via Tarantool-patches
2021-05-14 11:27 ` Igor Munkin via Tarantool-patches
2021-05-10 22:09 ` [Tarantool-patches] [PATCH luajit 3/3] FFI/ARM64/OSX: Fix vararg call handling Igor Munkin via Tarantool-patches
2021-05-11 11:07 ` Sergey Kaplun via Tarantool-patches
2021-05-11 11:31 ` Igor Munkin via Tarantool-patches
2021-05-12 16:11 ` Sergey Ostanevich via Tarantool-patches [this message]
2021-05-12 21:59 ` Igor Munkin via Tarantool-patches
2021-05-13 9:50 ` Sergey Ostanevich via Tarantool-patches
2021-05-13 10:44 ` Igor Munkin via Tarantool-patches
2021-05-14 10:10 ` Sergey Ostanevich via Tarantool-patches
2021-05-14 10:31 ` Igor Munkin via Tarantool-patches
2021-05-19 15:38 ` [Tarantool-patches] [PATCH luajit 0/3] Basic fixes for LuaJIT on ARM64 Macs Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2922F816-67DD-45D0-8F97-6CA2EB36F66E@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=sergos@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 3/3] FFI/ARM64/OSX: Fix vararg call handling.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox