From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C859A6EC5B; Fri, 14 May 2021 14:36:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C859A6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620992199; bh=x1EJ09h/tRO4SyzhFrHoEpyO36BsjE5pnkU3lpwTy5U=; h=Date:In-Reply-To:To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=J63zWEUsI+4p1/shdW+h2lX+5c3EjIpBZT1vWNDT4nP8hbh2CUBbEy0vm9FqdnyZY l0YgW+lznob62V9nsVNEbnb/GPebVSWsBMj8Ykeu36WG6WdNzDi9W7ypuBZ9r0KfZh OW5ZO2vbwV5hG0Hr2wyYZhPIydRfyMjegs++P0oE= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 27CBE6EC5B for ; Fri, 14 May 2021 14:36:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 27CBE6EC5B Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1lhW7R-00042q-AO; Fri, 14 May 2021 14:36:37 +0300 Message-Id: <456180FD-E66E-4DC3-810A-1411ABF268E3@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_46CB6E98-7E78-4939-8FC8-091013D82480" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Fri, 14 May 2021 14:36:36 +0300 In-Reply-To: <20210511110305.GC3944@tarantool.org> To: Igor Munkin References: <20210511110305.GC3944@tarantool.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0BB6090B4F8997C21AA3492AFA30115D5182A05F5380850401FEC13237EF0531DDC1BB214E5742A55CBD0426FA0B58DAA4FE03354DBF320B1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AEA4A6B3AFC9B957C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE761966F250AC1AE21EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BD6CF32B5F8F9D404051EC4D7C1D0DA250198A464822A7B6ACC7F00164DA146DAFE8445B8C89999728AA50765F79006372A3B24BF85B2E607389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC80CABCCA60F52D7EBF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C0CABCCA60F52D7EB03F1AB874ED890284AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C34FB8A72B20BA87CFBA3038C0950A5D36B5C8C57E37DE458B0BC6067A898B09E46D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7D151390FFDBF6399731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A588765553621F5EA3BD156DC0CA7D27A9C4A16B8BC2DF6397D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75438CC92D4039F4E2410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C53592357E805773E009DB94FF5F6B1D7406E759CE139DB92D71C1684D515FE432BE283750DF8AAF1D7E09C32AA3244C662E97BC5E20C1DF0DE7169149D7228464EE5813BBCA3A9DFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoybArHp+PQVSNVYh5RWF5Q== X-Mailru-Sender: 455D65AE3A139168626D8C76E86D3AC040AD3C78CA8BC8B0A3002AA935BC96CADDAC019A3742A8B676D79013C85012CDC77752E0C033A69E4BBE7EBD99111A499D0AB74157175C036C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] OSX/iOS: Handle iOS simulator and ARM64 Macs. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" --Apple-Mail=_46CB6E98-7E78-4939-8FC8-091013D82480 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Thanks for the patch, LGTM. Sergos > On 11 May 2021, at 14:03, Igor Munkin wrote: >=20 > Sergey, >=20 > Thanks for your review! I've made some minor changes to associate this > patch with the proper issue[1]. Diff is below: >=20 > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >=20 > diff --git = a/test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua = b/test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua > similarity index 82% > rename from = test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua > rename to = test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua > index b23dd712..7110e351 100644 > --- a/test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua > +++ b/test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua > @@ -1,6 +1,6 @@ > local tap =3D require('tap') >=20 > -local test =3D tap.test('gh-5983-jit-library-smoke-tests') > +local test =3D tap.test('gh-6065-jit-library-smoke-tests') > test:plan(1) >=20 > -- Just check whether LuaJIT is built with JIT support. Otherwise, >=20 > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >=20 > On 11.05.21, Sergey Kaplun wrote: >>=20 >> Hi, Igor! >>=20 >> Thanks for the patch! LGTM! >=20 > Added your tag: > | Reviewed-by: Sergey Kaplun > >=20 >>=20 >> On 11.05.21, Igor Munkin wrote: >>> From: Mike Pall >>=20 >> Side note: I am a little bit confused by this line (I thought that it = is >> a part of the commit message). May be it is better to drop it or to >> write like: >=20 > Hm, this looks like a common practice if *you* send *someone's* patch = to > be applied. IIRC, git am takes the entry below as commit author. >=20 >>=20 >> | # From: Mike Pall >>=20 >>>=20 >>> (cherry picked from commit 2e2fb8f6b5118e1a7996b76600c6ee98bfd5f203) >>>=20 >>> After Apple released Macs working on ARM64, the previous recipe in >>> lj_arch.h for detecting various Apple platforms is not valid = anymore. >>> Fortunately, there is a system header (i.e. TargetConditionals.h), >>> provided by SDK with the proper defines to be set. Starting from = this >>> patch, LuaJIT identifies Apple hosts via this header. >>>=20 >>> Since testing machinery assumes that LuaJIT is built with JIT = support >>> being enabled unconditionally, a smoke test for it is also added >>> alongside with this patch. >>>=20 >>> Igor Munkin: >>> * added the description and the test for the problem >>> * backported the original patch to tarantool/luajit repo >>>=20 >=20 > Mentioned the issue[1]: > | Resolves tarantool/tarantool#6065 >=20 >>> Part of tarantool/tarantool#5629 >>> Relates to tarantool/tarantool#5983 >>>=20 >>> Signed-off-by: Igor Munkin > >>> --- >>=20 >> >>=20 >>=20 >> --=20 >> Best regards, >> Sergey Kaplun >=20 > [1]: https://github.com/tarantool/tarantool/issues/6065 = >=20 > --=20 > Best regards, > IM --Apple-Mail=_46CB6E98-7E78-4939-8FC8-091013D82480 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Thanks for the patch, LGTM.

Sergos

On 11 = May 2021, at 14:03, Igor Munkin <imun@tarantool.org> wrote:

Sergey,

Thanks for your review! I've made some minor changes to = associate this
patch with the proper issue[1]. Diff is below:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D

diff --git = a/test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua = b/test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua
similarity = index 82%
rename from = test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua
rename to = test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua
index = b23dd712..7110e351 100644
--- = a/test/tarantool-tests/gh-5983-jit-library-smoke-tests.test.lua
+++ = b/test/tarantool-tests/gh-6065-jit-library-smoke-tests.test.lua
@@ -1,6 +1,6 = @@
local tap =3D = require('tap')

-local test =3D = tap.test('gh-5983-jit-library-smoke-tests')
+local test =3D= tap.test('gh-6065-jit-library-smoke-tests')
test:plan(1)

-- Just check whether LuaJIT is built with JIT support. = Otherwise,

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D

On 11.05.21, Sergey Kaplun wrote:

Hi, Igor!

Thanks for the patch! = LGTM!

Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>


On 11.05.21, Igor Munkin wrote:
From: Mike Pall <mike>

Side note: I am a little bit = confused by this line (I thought that it is
a part of the = commit message). May be it is better to drop it or to
write = like:

Hm, this looks like a common practice if *you* send = *someone's* patch to
be applied. IIRC, git am takes the entry below as commit = author.


| # From: Mike Pall <mike>


(cherry = picked from commit 2e2fb8f6b5118e1a7996b76600c6ee98bfd5f203)

After Apple released Macs working on ARM64, = the previous recipe in
lj_arch.h for detecting various = Apple platforms is not valid anymore.
Fortunately, there = is a system header (i.e. TargetConditionals.h),
provided = by SDK with the proper defines to be set. Starting from this
patch, LuaJIT identifies Apple hosts via this header.

Since testing machinery assumes that LuaJIT is = built with JIT support
being enabled unconditionally, a = smoke test for it is also added
alongside with this = patch.

Igor Munkin:
* added = the description and the test for the problem
* backported = the original patch to tarantool/luajit repo


Mentioned the issue[1]:
| Resolves tarantool/tarantool#6065

Part of = tarantool/tarantool#5629
Relates to = tarantool/tarantool#5983

Signed-off-by: = Igor Munkin <imun@tarantool.org>
---

<snipped>


-- 
Best = regards,
Sergey Kaplun

[1]: https://github.com/tarantool/tarantool/issues/6065

-- 
Best = regards,
IM

= --Apple-Mail=_46CB6E98-7E78-4939-8FC8-091013D82480--