From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Konstantin Osipov <kostja@tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 1/5] sql: introduce structs assembling DDL arguments during parsing
Date: Thu, 24 Jan 2019 13:47:48 +0300 [thread overview]
Message-ID: <4029AB62-F67D-45F0-9370-2F3A37CB9D09@tarantool.org> (raw)
In-Reply-To: <20190124083630.GC3573@chai>
> On 24 Jan 2019, at 11:36, Konstantin Osipov <kostja@tarantool.org> wrote:
>
> * Nikita Pettik <korablev@tarantool.org> [19/01/23 23:01]:
>> + /**
>> + * One of parse_def structures which are used to
>> + * assemble and carry arguments of DDL routines
>> + * from parse.y
>> + */
>> + void *alter_entity_def;
>
> Please consider adding a type code to the base entity def, so that
> you can use a base struct reference rather than void *.
Please, look at code and explain why do we need type
code? At first I added it, but it turned out that such code
was completely useless. The only real usage was to
assert that type of structure matches with its code.
next prev parent reply other threads:[~2019-01-24 10:47 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 17:56 [tarantool-patches] [PATCH v2 0/5] Introduce ALTER TABLE ADD CONSTRAINT UNIQUE/PK Nikita Pettik
2019-01-23 17:56 ` [tarantool-patches] [PATCH v2 1/5] sql: introduce structs assembling DDL arguments during parsing Nikita Pettik
2019-01-24 8:36 ` [tarantool-patches] " Konstantin Osipov
2019-01-24 10:47 ` n.pettik [this message]
2019-01-24 12:30 ` Konstantin Osipov
2019-01-29 19:03 ` n.pettik
2019-01-29 19:29 ` Vladislav Shpilevoy
2019-01-29 20:04 ` n.pettik
2019-01-29 20:20 ` Vladislav Shpilevoy
2019-01-29 21:25 ` n.pettik
2019-01-31 19:32 ` n.pettik
2019-02-04 15:25 ` Vladislav Shpilevoy
2019-02-08 14:25 ` n.pettik
2019-02-15 20:13 ` Vladislav Shpilevoy
2019-02-27 22:56 ` n.pettik
2019-03-12 12:50 ` Vladislav Shpilevoy
2019-03-14 18:13 ` n.pettik
2019-03-25 11:25 ` Vladislav Shpilevoy
2019-03-26 18:01 ` n.pettik
2019-03-26 18:06 ` Vladislav Shpilevoy
2019-03-27 13:00 ` n.pettik
2019-03-27 13:29 ` Vladislav Shpilevoy
2019-03-27 13:44 ` n.pettik
2019-03-27 14:03 ` Vladislav Shpilevoy
2019-03-27 14:11 ` n.pettik
2019-01-23 17:56 ` [tarantool-patches] [PATCH v2 2/5] sql: rework ALTER TABLE grammar Nikita Pettik
2019-01-23 17:56 ` [tarantool-patches] [PATCH v2 3/5] sql: refactor getNewIid() function Nikita Pettik
2019-01-23 17:56 ` [tarantool-patches] [PATCH v2 4/5] sql: fix error message for improperly created index Nikita Pettik
2019-02-08 17:14 ` [tarantool-patches] " Konstantin Osipov
2019-01-23 17:56 ` [tarantool-patches] [PATCH v2 5/5] sql: introduce ALTER TABLE ADD CONSTRAINT UNIQUE/PRIMARY KEY Nikita Pettik
2019-01-24 8:31 ` [tarantool-patches] " Konstantin Osipov
2019-01-29 19:29 ` Vladislav Shpilevoy
2019-02-08 17:16 ` Konstantin Osipov
2019-02-08 17:36 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4029AB62-F67D-45F0-9370-2F3A37CB9D09@tarantool.org \
--to=korablev@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v2 1/5] sql: introduce structs assembling DDL arguments during parsing' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox