From: Konstantin Osipov <kostja@tarantool.org>
To: tarantool-patches@freelists.org
Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 5/5] sql: introduce ALTER TABLE ADD CONSTRAINT UNIQUE/PRIMARY KEY
Date: Fri, 8 Feb 2019 20:16:36 +0300 [thread overview]
Message-ID: <20190208171636.GF4588@chai> (raw)
In-Reply-To: <6dacbf399fb84152368b47576b42b4bc3da23e78.1548265148.git.korablev@tarantool.org>
* Nikita Pettik <korablev@tarantool.org> [19/01/23 21:03]:
> +static void
> +pk_check_existence(struct Parse *parse, uint32_t space_id, int _index_cursor)
Tarantool function naming scheme is
modulename-subject-verb-object.
I applaud to an attempt to make the code follow Tarantool coding
style, but please do follow it then.
--
Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
http://tarantool.io - www.twitter.com/kostja_osipov
next prev parent reply other threads:[~2019-02-08 17:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 17:56 [tarantool-patches] [PATCH v2 0/5] Introduce ALTER TABLE ADD CONSTRAINT UNIQUE/PK Nikita Pettik
2019-01-23 17:56 ` [tarantool-patches] [PATCH v2 1/5] sql: introduce structs assembling DDL arguments during parsing Nikita Pettik
2019-01-24 8:36 ` [tarantool-patches] " Konstantin Osipov
2019-01-24 10:47 ` n.pettik
2019-01-24 12:30 ` Konstantin Osipov
2019-01-29 19:03 ` n.pettik
2019-01-29 19:29 ` Vladislav Shpilevoy
2019-01-29 20:04 ` n.pettik
2019-01-29 20:20 ` Vladislav Shpilevoy
2019-01-29 21:25 ` n.pettik
2019-01-31 19:32 ` n.pettik
2019-02-04 15:25 ` Vladislav Shpilevoy
2019-02-08 14:25 ` n.pettik
2019-02-15 20:13 ` Vladislav Shpilevoy
2019-02-27 22:56 ` n.pettik
2019-03-12 12:50 ` Vladislav Shpilevoy
2019-03-14 18:13 ` n.pettik
2019-03-25 11:25 ` Vladislav Shpilevoy
2019-03-26 18:01 ` n.pettik
2019-03-26 18:06 ` Vladislav Shpilevoy
2019-03-27 13:00 ` n.pettik
2019-03-27 13:29 ` Vladislav Shpilevoy
2019-03-27 13:44 ` n.pettik
2019-03-27 14:03 ` Vladislav Shpilevoy
2019-03-27 14:11 ` n.pettik
2019-01-23 17:56 ` [tarantool-patches] [PATCH v2 2/5] sql: rework ALTER TABLE grammar Nikita Pettik
2019-01-23 17:56 ` [tarantool-patches] [PATCH v2 3/5] sql: refactor getNewIid() function Nikita Pettik
2019-01-23 17:56 ` [tarantool-patches] [PATCH v2 4/5] sql: fix error message for improperly created index Nikita Pettik
2019-02-08 17:14 ` [tarantool-patches] " Konstantin Osipov
2019-01-23 17:56 ` [tarantool-patches] [PATCH v2 5/5] sql: introduce ALTER TABLE ADD CONSTRAINT UNIQUE/PRIMARY KEY Nikita Pettik
2019-01-24 8:31 ` [tarantool-patches] " Konstantin Osipov
2019-01-29 19:29 ` Vladislav Shpilevoy
2019-02-08 17:16 ` Konstantin Osipov [this message]
2019-02-08 17:36 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190208171636.GF4588@chai \
--to=kostja@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v2 5/5] sql: introduce ALTER TABLE ADD CONSTRAINT UNIQUE/PRIMARY KEY' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox