From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C47EE25553
	for <tarantool-patches@freelists.org>; Thu, 24 Jan 2019 05:47:52 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id gjE9UeyNZh1N for <tarantool-patches@freelists.org>;
	Thu, 24 Jan 2019 05:47:52 -0500 (EST)
Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id F3FBD22678
	for <tarantool-patches@freelists.org>; Thu, 24 Jan 2019 05:47:51 -0500 (EST)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: [tarantool-patches] Re: [PATCH v2 1/5] sql: introduce structs assembling DDL arguments
 during parsing
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <20190124083630.GC3573@chai>
Date: Thu, 24 Jan 2019 13:47:48 +0300
Content-Transfer-Encoding: 7bit
Message-Id: <4029AB62-F67D-45F0-9370-2F3A37CB9D09@tarantool.org>
References: <cover.1548265148.git.korablev@tarantool.org>
 <0fcc585532a1f1200a7dfd4a8e911ecf9f2c94aa.1548265148.git.korablev@tarantool.org>
 <20190124083630.GC3573@chai>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Konstantin Osipov <kostja@tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>



> On 24 Jan 2019, at 11:36, Konstantin Osipov <kostja@tarantool.org> wrote:
> 
> * Nikita Pettik <korablev@tarantool.org> [19/01/23 23:01]:
>> +	/**
>> +	 * One of parse_def structures which are used to
>> +	 * assemble and carry arguments of DDL routines
>> +	 * from parse.y
>> +	 */
>> +	void *alter_entity_def;
> 
> Please consider adding a type code to the base entity def, so that
> you can use a base struct reference rather than void *. 

Please, look at code and explain why do we need type
code? At first I added it, but it turned out that such code
was completely useless. The only real usage was to
assert that type of structure matches with its code.