From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/7] replication: always send raft state to subscribers
Date: Tue, 15 Jun 2021 22:53:23 +0200 [thread overview]
Message-ID: <3dc87744-6880-78a3-b77e-3a8811763c39@tarantool.org> (raw)
In-Reply-To: <ee5c37f76190c26139b5873c195f29b89ffdccd1.1623331925.git.sergepetrenko@tarantool.org>
Thanks for working on this!
On 10.06.2021 15:32, Serge Petrenko via Tarantool-patches wrote:
> Tarantool used to send out raft state on subscribe only when raft was
> enabled. This was a safeguard against partially-upgraded clusters, where
> some nodes had no clue about Raft messages and couldn't handle them
> properly.
>
> Actually, Raft state should be sent out always. For example, promote
> bumps Raft term, even when raft is disabled, and it's important that
> everyone in cluster has the same term, for the sake of promote at least.
>
> So, send out Raft state to every subscriber with version >= 2.6.0
> (that's when Raft was introduced).
>
> Closes #5438
> ---
> src/box/box.cc | 11 +--
> test/replication/gh-5438-raft-state.result | 73 ++++++++++++++++++++
> test/replication/gh-5438-raft-state.test.lua | 30 ++++++++
The test still works when I revert box.cc changes.
next prev parent reply other threads:[~2021-06-15 20:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 13:32 [Tarantool-patches] [PATCH 0/7] forbid implicit limbo ownership transition Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 1/7] replication: always send raft state to subscribers Serge Petrenko via Tarantool-patches
2021-06-10 16:47 ` Cyrill Gorcunov via Tarantool-patches
2021-06-11 8:43 ` Serge Petrenko via Tarantool-patches
2021-06-11 8:44 ` Cyrill Gorcunov via Tarantool-patches
2021-06-15 20:53 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 2/7] replication: forbid implicit limbo owner transition Serge Petrenko via Tarantool-patches
2021-06-15 20:55 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-18 22:49 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 10:13 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 3/7] txn_limbo: fix promote term filtering Serge Petrenko via Tarantool-patches
2021-06-15 20:57 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-18 22:49 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 8:55 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 4/7] txn_limbo: persist the latest effective promote in snapshot Serge Petrenko via Tarantool-patches
2021-06-15 20:59 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 5/7] replication: send latest effective promote in initial join Serge Petrenko via Tarantool-patches
2021-06-15 21:00 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-18 22:52 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 10:12 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 6/7] box: introduce `box.ctl.demote` Serge Petrenko via Tarantool-patches
2021-06-18 22:52 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 14:56 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 7/7] box: make promote/demote always bump the term Serge Petrenko via Tarantool-patches
2021-06-15 21:00 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-18 22:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 15:02 ` Serge Petrenko via Tarantool-patches
2021-06-15 20:53 ` [Tarantool-patches] [PATCH 0/7] forbid implicit limbo ownership transition Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dc87744-6880-78a3-b77e-3a8811763c39@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/7] replication: always send raft state to subscribers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox