From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 7/7] box: make promote/demote always bump the term
Date: Fri, 18 Jun 2021 00:00:21 +0300 [thread overview]
Message-ID: <2473918a-ea2c-9df8-d1ba-d80e79e603fa@tarantool.org> (raw)
In-Reply-To: <4cc40dd9-f86d-d341-823c-d617e4c86c80@tarantool.org>
16.06.2021 00:00, Vladislav Shpilevoy пишет:
> Thanks for the patch!
>
>> diff --git a/src/lib/raft/raft.c b/src/lib/raft/raft.c
>> index 247c7a71a..1de05727f 100644
>> --- a/src/lib/raft/raft.c
>> +++ b/src/lib/raft/raft.c
>> @@ -983,8 +983,7 @@ raft_cfg_vclock(struct raft *raft, const struct vclock *vclock)
>> void
>> raft_new_term(struct raft *raft)
>> {
>> - if (raft->is_enabled)
>> - raft_sm_schedule_new_term(raft, raft->volatile_term + 1);
>> + raft_sm_schedule_new_term(raft, raft->volatile_term + 1);
>> }
> Could you please make it a separate commit + add a unit test?
Thanks for the reivew!
Sure. Please see v2 of the patchset.
--
Serge Petrenko
next prev parent reply other threads:[~2021-06-17 21:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 13:32 [Tarantool-patches] [PATCH 0/7] forbid implicit limbo ownership transition Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 1/7] replication: always send raft state to subscribers Serge Petrenko via Tarantool-patches
2021-06-10 16:47 ` Cyrill Gorcunov via Tarantool-patches
2021-06-11 8:43 ` Serge Petrenko via Tarantool-patches
2021-06-11 8:44 ` Cyrill Gorcunov via Tarantool-patches
2021-06-15 20:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 2/7] replication: forbid implicit limbo owner transition Serge Petrenko via Tarantool-patches
2021-06-15 20:55 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-18 22:49 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 10:13 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 3/7] txn_limbo: fix promote term filtering Serge Petrenko via Tarantool-patches
2021-06-15 20:57 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-18 22:49 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 8:55 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 4/7] txn_limbo: persist the latest effective promote in snapshot Serge Petrenko via Tarantool-patches
2021-06-15 20:59 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 5/7] replication: send latest effective promote in initial join Serge Petrenko via Tarantool-patches
2021-06-15 21:00 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches
2021-06-18 22:52 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 10:12 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 6/7] box: introduce `box.ctl.demote` Serge Petrenko via Tarantool-patches
2021-06-18 22:52 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 14:56 ` Serge Petrenko via Tarantool-patches
2021-06-10 13:32 ` [Tarantool-patches] [PATCH 7/7] box: make promote/demote always bump the term Serge Petrenko via Tarantool-patches
2021-06-15 21:00 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-17 21:00 ` Serge Petrenko via Tarantool-patches [this message]
2021-06-18 22:53 ` Vladislav Shpilevoy via Tarantool-patches
2021-06-21 15:02 ` Serge Petrenko via Tarantool-patches
2021-06-15 20:53 ` [Tarantool-patches] [PATCH 0/7] forbid implicit limbo ownership transition Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2473918a-ea2c-9df8-d1ba-d80e79e603fa@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 7/7] box: make promote/demote always bump the term' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox