From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 31B2C6E200; Fri, 18 Jun 2021 00:02:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 31B2C6E200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1623963764; bh=BpwJ/sI6xytU2NTPjT3J7Zf38DykEcRtFOL2LDbK9ig=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=D8yUynvEau9Hcu0Cd9WJ0x1K1hdvSbALTDFzRNzjl31M6Wk6mEZ0QeZFMClH1c7YH w6buxbu9jfMhEVSl6h2HPhahC2vTPXju6WCrpP217sgSA2DlkK9f9qYLn8gFsbR4zn YoE2Jo4dZEneycKtYiY/WhV919r7yLnJzIhqlNKM= Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 68D726E202 for ; Fri, 18 Jun 2021 00:00:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 68D726E202 Received: by smtp54.i.mail.ru with esmtpa (envelope-from ) id 1ltz7d-0004G4-RX; Fri, 18 Jun 2021 00:00:22 +0300 To: Vladislav Shpilevoy , gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: <4cc40dd9-f86d-d341-823c-d617e4c86c80@tarantool.org> Message-ID: <2473918a-ea2c-9df8-d1ba-d80e79e603fa@tarantool.org> Date: Fri, 18 Jun 2021 00:00:21 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <4cc40dd9-f86d-d341-823c-d617e4c86c80@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91C2C07775F13263AFA27A2C0BAE5D906003D228FC84EF29400894C459B0CD1B969DD3D17F67D40BC8C5D68F443310CC8AE11324F96DF83CBF4C996BC25162494 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE782A779A89F7D69B2C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE705C173BDDADFC82AEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BD6CF32B5F8F9D404C51E40E9E7B0526939EBDE4F879C7367CC7F00164DA146DAFE8445B8C89999728AA50765F79006375FFD5C25497261569FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C33B72D73EA5828B68117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CFF4AF32A017141CDEBA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B62B215FA7A634AA1D76E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7CB24F08513AFFAC7943847C11F186F3C59DAA53EE0834AAEE X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824A2A04A2ABAA09D25379311020FFC8D4AD7067FEF890167A54D649C4BC85114D28 X-C1DE0DAB: 0D63561A33F958A55E0000A75713976D963C82BF8E9778301D5450E9F039D9ABD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A08F09726D78E07BC9A2232DA34FF708E3305F46065BF3A03DAEE7193EEF0609B574869A4425A64F1D7E09C32AA3244C8035923553079BD4F0698AD8071A8E9330452B15D76AEC14FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojo2TEchKDd+cXx45mH3E1Xw== X-Mailru-Sender: 583F1D7ACE8F49BD9DF7A8DAE6E2B08A7335C388A1FBB6A394F7358478E1034664F355F2DF6DC2AA424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 7/7] box: make promote/demote always bump the term X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 16.06.2021 00:00, Vladislav Shpilevoy пишет: > Thanks for the patch! > >> diff --git a/src/lib/raft/raft.c b/src/lib/raft/raft.c >> index 247c7a71a..1de05727f 100644 >> --- a/src/lib/raft/raft.c >> +++ b/src/lib/raft/raft.c >> @@ -983,8 +983,7 @@ raft_cfg_vclock(struct raft *raft, const struct vclock *vclock) >> void >> raft_new_term(struct raft *raft) >> { >> - if (raft->is_enabled) >> - raft_sm_schedule_new_term(raft, raft->volatile_term + 1); >> + raft_sm_schedule_new_term(raft, raft->volatile_term + 1); >> } > Could you please make it a separate commit + add a unit test? Thanks for the reivew! Sure. Please see v2 of the patchset. -- Serge Petrenko