From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 84C0E6EC55; Tue, 15 Jun 2021 23:53:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 84C0E6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1623790432; bh=oWObik/VFBAXZg2TGC2no+zO1CUG8nkDPWfoBja90xg=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=R7ffxkQHgzZktRmOGRViUUUWph4y66vVrpw7HrntAXkAJi9IryJJeE+iXYcJdmO+s rFe1eoPjsaIZekE1GRg6qetvB+1A21cSueSZeW9w6PG4Wdy2zRaPIAS9AK+gCWRwxf I+3RWAshpZicuOZUtac7/31n6RFpqxiFf4QfkNl8= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5768C6EC55 for ; Tue, 15 Jun 2021 23:53:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5768C6EC55 Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1ltG3o-0000c7-KN; Tue, 15 Jun 2021 23:53:25 +0300 To: Serge Petrenko , gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: Message-ID: <3dc87744-6880-78a3-b77e-3a8811763c39@tarantool.org> Date: Tue, 15 Jun 2021 22:53:23 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C54EECC50CDFE52CD8E09EC742E3E75A787182A05F53808504055210AF26C7C37BD5DCF9A0499CC61D154E1ADA74D7F8F17E3CD12C995AD3140 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FCFCB92DA8654BB0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B24541F05F0BFC9F8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D87CCF2ACA7AA9195EA3EFF4EFB5CA46F5117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE437C869540D2AB0FA9539A8B24243104D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE39E541A154B51D14B2D242C3BD2E3F4C6C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BBEA499411984DA1EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C97831C4E36AE33D58368FDFDF0179112761E5 X-C1DE0DAB: 0D63561A33F958A5907D2E5AA300E6960EE500F0E322D977D2BD01540319AFB0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FBC5FED0552DA851410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A5970F8A4685C8AB025EF4B01939868B3CF19D571170DD7328D8F947EB0BB1ECAEC1C4CE5F4B89611D7E09C32AA3244C4270B72464AA03B27BB2CED6B7C3B4A269B6CAE0477E908DFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj6OL1iHTyIM2EY+blPzeUpg== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA31108F329124C4DAE65CF324A4B53E60F3ADB105C5A8EBBFBBC107784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/7] replication: always send raft state to subscribers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for working on this! On 10.06.2021 15:32, Serge Petrenko via Tarantool-patches wrote: > Tarantool used to send out raft state on subscribe only when raft was > enabled. This was a safeguard against partially-upgraded clusters, where > some nodes had no clue about Raft messages and couldn't handle them > properly. > > Actually, Raft state should be sent out always. For example, promote > bumps Raft term, even when raft is disabled, and it's important that > everyone in cluster has the same term, for the sake of promote at least. > > So, send out Raft state to every subscriber with version >= 2.6.0 > (that's when Raft was introduced). > > Closes #5438 > --- > src/box/box.cc | 11 +-- > test/replication/gh-5438-raft-state.result | 73 ++++++++++++++++++++ > test/replication/gh-5438-raft-state.test.lua | 30 ++++++++ The test still works when I revert box.cc changes.