Re: [Tarantool-patches] [PATCH luajit] ci: conditionally install lua-cjson for perf job

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1695 bytes --]

Hi, Sergey!

A few things worry me: we still don't know the root cause of the problem.

The proposed patch merely reduces the frequency of module installations.

And if an installation is required, the installation will still break.

See comments inline.

Sergey

On 4/23/26 20:08, Sergey Kaplun wrote:
> We have encountered the flakiness of the network on our CI runners. It
> happens only on lua-cjson installation and only in some particular job
> run.
>
> This patch helps to deal with it by installing this package only if it
s/helps to deal with it/helps to reduce a number of installations/
> is not installed in the system. Also, it installs it only for Lua 5.1,
> which is compatible with LuaJIT.
> ---
>
> Branch:https://github.com/tarantool/luajit/tree/skaplun/ci-perf-install-conditionally-lua-cjson
>
>   .github/actions/setup-performance/action.yml | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/.github/actions/setup-performance/action.yml b/.github/actions/setup-performance/action.yml
> index 4e0e1929..3c2a8230 100644
> --- a/.github/actions/setup-performance/action.yml
> +++ b/.github/actions/setup-performance/action.yml
> @@ -11,7 +11,9 @@ runs:
>           apt install -y curl luarocks util-linux
>         shell: bash
>       - name: Install Lua modules
> -      run: luarocks install lua-cjson
> +      run: >
> +        luarocks --lua-version=5.1 show lua-cjson ||
> +        luarocks --lua-version=5.1 install lua-cjson
Why do we need specifying Lua version now? Previously, it worked without 
setting exact version.
>         shell: bash
>       - name: Run script to setup Linux environment
>         run: sh ./perf/helpers/setup_env.sh

[-- Attachment #2: Type: text/html, Size: 3065 bytes --]