Tarantool development patches archive
 help / color / mirror / Atom feed
From: Evgeniy Temirgaleev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Sergey Kaplun" <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches]  [PATCH luajit] ci: conditionally install lua-cjson for perf job
Date: Fri, 24 Apr 2026 18:14:29 +0300	[thread overview]
Message-ID: <1777043669.38227115@f159.i.mail.ru> (raw)
In-Reply-To: <20260423170806.9647-1-skaplun@tarantool.org>

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

LGTM

--
Evgeniy Temirgaleev
Отправлено из Почты Mail ( https://trk.mail.ru/c/zzm979 )

> 
> От кого: Sergey Kaplun <skaplun@tarantool.org>
> Кому: Sergey Bronnikov <sergeyb@tarantool.org>, Evgeniy Temirgaleev
> <e.temirgaleev@tarantool.org>
> Копия: tarantool-patches@dev.tarantool.org, Sergey Kaplun
> <skaplun@tarantool.org>
> Дата: Четверг, 23 апреля 2026, 20:09 +03:00
> We have encountered the flakiness of the network on our CI runners. It
> happens only on lua-cjson installation and only in some particular job
> run.
> 
> This patch helps to deal with it by installing this package only if it
> is not installed in the system. Also, it installs it only for Lua 5.1,
> which is compatible with LuaJIT.
> ---
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/ci-perf-install-conditionally-lua-cjson
> 
> 
> .github/actions/setup-performance/action.yml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/.github/actions/setup-performance/action.yml
> b/.github/actions/setup-performance/action.yml
> index 4e0e1929..3c2a8230 100644
> --- a/.github/actions/setup-performance/action.yml
> +++ b/.github/actions/setup-performance/action.yml
> @@ -11,7 +11,9 @@ runs:
> apt install -y curl luarocks util-linux
> shell: bash
> - name: Install Lua modules
> - run: luarocks install lua-cjson
> + run: >
> + luarocks --lua-version=5.1 show lua-cjson ||
> + luarocks --lua-version=5.1 install lua-cjson
> shell: bash
> - name: Run script to setup Linux environment
> run: sh ./perf/helpers/setup_env.sh
> --
> 2.53.0
>

[-- Attachment #2: Type: text/html, Size: 2458 bytes --]

  reply	other threads:[~2026-04-24 15:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23 17:08 Sergey Kaplun via Tarantool-patches
2026-04-24 15:14 ` Evgeniy Temirgaleev via Tarantool-patches [this message]
2026-04-28 10:55 ` Sergey Bronnikov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1777043669.38227115@f159.i.mail.ru \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=e.temirgaleev@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches]  [PATCH luajit] ci: conditionally install lua-cjson for perf job' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox