From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DB3B11B5DDD6; Tue, 28 Apr 2026 13:55:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DB3B11B5DDD6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1777373750; bh=959orQDSz/0QEb5gq/ID2NnhGj1oEkhePojtVSsPQ0c=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=x8bwX9trfu0I0hVBJIkDHZanbzs787SEgObmtZSMmjzNCILjE2tk3gKpbV4BwAKa2 5J5UOkETyn7kCNW0kZ3kRP+mbL7NI3oSXxKJPEA0lJyBojcVBvs467pkNUUh45U0hD 3iS/VLE3Dnqmc7NZOoBW4YkzSAgcBNcs9X4ywCcM= Received: from send219.i.mail.ru (send219.i.mail.ru [95.163.59.58]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C28151B5DDD5 for ; Tue, 28 Apr 2026 13:55:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C28151B5DDD5 Received: by exim-smtp-579cdc88d9-v59w2 with esmtpa (envelope-from ) id 1wHg6U-00000000RqM-3SN9; Tue, 28 Apr 2026 13:55:47 +0300 Content-Type: multipart/alternative; boundary="------------3jQFa81agOkFsES0bj25HwRi" Message-ID: <398afbb0-66c6-4935-878f-ed01356fe740@tarantool.org> Date: Tue, 28 Apr 2026 13:55:45 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun , Evgeniy Temirgaleev Cc: tarantool-patches@dev.tarantool.org References: <20260423170806.9647-1-skaplun@tarantool.org> Content-Language: en-US In-Reply-To: <20260423170806.9647-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9DA546775E7411B7C276EE57DE4164ADB826A139197C2F0A600894C459B0CD1B9AE1F0AB95CF1F81203AAE3001806DF103FD0A41690BB11681B0080415FBDEE06EC456C66D2279EA7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE789066434B85BF7C7EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063750E64749F09C4ED58638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2999DBFB38EE806642E070BE324C7D3C4ADA3D6401E22E150F6B57BC7E64490618DEB871D839B73339E8FC8737B5C224952D31B9D28593E51CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C04CF195F1528592878941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C01FD230EDC2DAED9B7B076A6E789B0E97A8DF7F3B2552694AD5FFEEA1DED7F25D49FD398EE364050F140C956E756FBB7A07FB45A5F6E725C8B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B735D20FCDD20D84075ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A557C2BFD2E8DCC1105002B1117B3ED6967A003A7C5CF59FE4559C6C5561145D6F823CB91A9FED034534781492E4B8EEAD85CCBA673D36D1A4BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65991BA4B00AABBF8ECF4605A375B2AF6AA17B898F104688B126721D141DA8F102BCDA1D4329FB25774B8341EE9D5BE9A0A2E6A5ADF28F20B92E8C1EFD2B5729B1B516EB1BE9FB583C86536EB022892E5344C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVW+UUD87bVUorqwmxmhikSM= X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F258845840AEDA9C592291FB0D8E165B5AC4796C437B9EE9D96D06760185EB6AF0195860645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ci: conditionally install lua-cjson for perf job X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------3jQFa81agOkFsES0bj25HwRi Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey! A few things worry me: we still don't know the root cause of the problem. The proposed patch merely reduces the frequency of module installations. And if an installation is required, the installation will still break. See comments inline. Sergey On 4/23/26 20:08, Sergey Kaplun wrote: > We have encountered the flakiness of the network on our CI runners. It > happens only on lua-cjson installation and only in some particular job > run. > > This patch helps to deal with it by installing this package only if it s/helps to deal with it/helps to reduce a number of installations/ > is not installed in the system. Also, it installs it only for Lua 5.1, > which is compatible with LuaJIT. > --- > > Branch:https://github.com/tarantool/luajit/tree/skaplun/ci-perf-install-conditionally-lua-cjson > > .github/actions/setup-performance/action.yml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/.github/actions/setup-performance/action.yml b/.github/actions/setup-performance/action.yml > index 4e0e1929..3c2a8230 100644 > --- a/.github/actions/setup-performance/action.yml > +++ b/.github/actions/setup-performance/action.yml > @@ -11,7 +11,9 @@ runs: > apt install -y curl luarocks util-linux > shell: bash > - name: Install Lua modules > - run: luarocks install lua-cjson > + run: > > + luarocks --lua-version=5.1 show lua-cjson || > + luarocks --lua-version=5.1 install lua-cjson Why do we need specifying Lua version now? Previously, it worked without setting exact version. > shell: bash > - name: Run script to setup Linux environment > run: sh ./perf/helpers/setup_env.sh --------------3jQFa81agOkFsES0bj25HwRi Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey!

A few things worry me: we still don't know the root cause of the problem.

The proposed patch merely reduces the frequency of module installations.

And if an installation is required, the installation will still break.

See comments inline.

Sergey

On 4/23/26 20:08, Sergey Kaplun wrote:
We have encountered the flakiness of the network on our CI runners. It
happens only on lua-cjson installation and only in some particular job
run.

This patch helps to deal with it by installing this package only if it
s/helps to deal with it/helps to reduce a number of installations/ 
is not installed in the system. Also, it installs it only for Lua 5.1,
which is compatible with LuaJIT.
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/ci-perf-install-conditionally-lua-cjson

 .github/actions/setup-performance/action.yml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.github/actions/setup-performance/action.yml b/.github/actions/setup-performance/action.yml
index 4e0e1929..3c2a8230 100644
--- a/.github/actions/setup-performance/action.yml
+++ b/.github/actions/setup-performance/action.yml
@@ -11,7 +11,9 @@ runs:
         apt install -y curl luarocks util-linux
       shell: bash
     - name: Install Lua modules
-      run: luarocks install lua-cjson
+      run: >
+        luarocks --lua-version=5.1 show lua-cjson ||
+        luarocks --lua-version=5.1 install lua-cjson
Why do we need specifying Lua version now? Previously, it worked without setting exact version. 
       shell: bash
     - name: Run script to setup Linux environment
       run: sh ./perf/helpers/setup_env.sh
--------------3jQFa81agOkFsES0bj25HwRi--