Re: [Tarantool-patches] [PATCH v5 8/8] datetime: changelog for datetime module

[Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

18.08.2021 02:44, Safin Timur пишет:
> On 17.08.2021 15:16, Serge Petrenko wrote:
>>
>>
>> 16.08.2021 02:59, Timur Safin via Tarantool-patches пишет:
>>> Introduced new date/time/interval types support to lua and storage 
>>> engines.
>>>
>>> Closes #5941
>>> Closes #5946
>>> ---
>>>   changelogs/unreleased/gh-5941-datetime-type-support.md | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>   create mode 100644 
>>> changelogs/unreleased/gh-5941-datetime-type-support.md
>>>
>>> diff --git a/changelogs/unreleased/gh-5941-datetime-type-support.md 
>>> b/changelogs/unreleased/gh-5941-datetime-type-support.md
>>> new file mode 100644
>>> index 000000000..3c755008e
>>> --- /dev/null
>>> +++ b/changelogs/unreleased/gh-5941-datetime-type-support.md
>>> @@ -0,0 +1,4 @@
>>> +## feature/lua/datetime
>>> +
>>> + * Introduce new builtin module for date/time/interval support - 
>>> `datetime.lua`.
>>> +   Support of new datetime type in storage engines (gh-5941, gh-5946).
>>
>> I'd extract the second line into a separate bullet.
>> Up to you.
>>
>>
>
> Made some changes
> -----------------------------------------------------------------
> diff --git a/changelogs/unreleased/gh-5941-datetime-type-support.md 
> b/changelogs/unreleased/gh-5941-datetime-type-support.md
> index 3c755008e..fb1f23077 100644
> --- a/changelogs/unreleased/gh-5941-datetime-type-support.md
> +++ b/changelogs/unreleased/gh-5941-datetime-type-support.md
> @@ -1,4 +1,6 @@
>  ## feature/lua/datetime
>
> - * Introduce new builtin module for date/time/interval support - 
> `datetime.lua`.
> -   Support of new datetime type in storage engines (gh-5941, gh-5946).
> + * Introduce new builtin module `datetime.lua` for date, time, and 
> interval
> +   support;
> + * Support of a new datetime type in storage engines allows to store 
> datetime
> +   fields and build indices with them (gh-5941, gh-5946).
> -----------------------------------------------------------------
>
> Thanks,
> Timur
Looks good, thanks!
This may be squashed into the 6th commit. Up to you.

-- 
Serge Petrenko