Re: [Tarantool-patches] [PATCHv4 0/2] lua: fix tarantool -e always enters interactive

[Leonid Vasiliev via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi! Thank you for the patchset.
LGTM.

On 3/11/21 3:05 PM, Artem Starshov wrote:
> Issue: https://github.com/tarantool/tarantool/issues/5040
> Branch: https://github.com/tarantool/tarantool/tree/artemreyt/gh-5040-interactive-mode-bug
> 
> Changes in v4:
>    * core:
>      - add wiki for setting error injections vi env: https://github.com/tarantool/tarantool/wiki/Error-injections;
>      - since now `panic()` is invoked in case of wrong value for errinj environment variable;
>      - some codestyle fixes;
>    * lua:
>      - add changelogs/unreleased/fix-tarantool-e-option.md;
>      - some codestyle fixes;
> 
> Artem Starshov (2):
>    core: add setting error injections via env
>    lua: fix tarantool -e always enters interactive mode
> 
>   .../unreleased/fix-tarantool-e-option.md      |   6 +
>   src/lib/core/errinj.c                         |  37 +++++
>   src/lib/core/errinj.h                         |   6 +
>   src/lua/init.c                                |  27 +++-
>   src/main.cc                                   |   3 +
>   ...5040-inter-mode-isatty-via-errinj.test.lua | 126 ++++++++++++++++++
>   test/app-tap/suite.ini                        |   1 +
>   .../errinj_set_with_enviroment_vars.test.lua  |  29 ++++
>   ...errinj_set_with_enviroment_vars_script.lua |  34 +++++
>   test/box-tap/suite.ini                        |   1 +
>   test/box/errinj.result                        |   1 +
>   11 files changed, 267 insertions(+), 4 deletions(-)
>   create mode 100644 changelogs/unreleased/fix-tarantool-e-option.md
>   create mode 100755 test/app-tap/gh-5040-inter-mode-isatty-via-errinj.test.lua
>   create mode 100755 test/box-tap/errinj_set_with_enviroment_vars.test.lua
>   create mode 100644 test/box-tap/errinj_set_with_enviroment_vars_script.lua
>