From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2E55A6F3C0; Thu, 11 Mar 2021 15:35:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2E55A6F3C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615466136; bh=mC/4X89FTwL/Bbx0XsKLomDSFllZXow5RDbqN4U/UGU=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=veFFPHjIs/t5mZtENEMLv+/dMrch7GhrplzHhlXk3ExWvqXVAa/etVj3rgNOeYYuY TXOXtABY8mKnsJli8AStXitRvYBoQ1peJIXbX568LZkvgENtrO74U/P56Px5+A/4ea y8+6bBVjJzE6z3WLy7VwaDvcl5iJ2c5LDKdirNnQ= Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 311C76F3C0 for ; Thu, 11 Mar 2021 15:35:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 311C76F3C0 Received: by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1lKKXM-0004Sv-5G; Thu, 11 Mar 2021 15:35:32 +0300 To: Artem Starshov , Alexander Turenko References: Message-ID: <27a6ad6f-6e58-081c-a379-bb64d41d50a1@tarantool.org> Date: Thu, 11 Mar 2021 15:34:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69B9676070C5F64E418DB309FBA590CF44700894C459B0CD1B9A51A4952A0190E4440AE7F76D4F06E5E6CCBBD94873830B702AB01EBACA1B0D0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70043D879A87EF1BCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371A4E0E763A740679EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664A9B589C57B9CBD95BF77B00987EDCF227613FB5035DDECA7389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A29E2F051442AF778941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6E5E764EB5D94DBD4CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249F89742133A00DB0976E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B56A390B5305F35C83AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE7B2B7C64F398C741067F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C3CD42BCEBB57B85E635872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9DE2850DD75B2526BE5BFE6E7EFDEDCD789D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46D5307A8293F13168C355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A566F8040E9BE59C422F659724156A29DA7653401C77EAE6ECD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B0359B88B232A0C6C27EC86C815ABE378F56782E5F87C25F5B37ECABF177A304EC2446C34D4A28D61D7E09C32AA3244CC3C30EFB8BFA18F583D931B540E224B830363D8B7DA7DD44927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojeUfzg2H8wDSDzBxe9XKZ/A== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769F99BF53F01FDF0A7943DDA504BF9879D5AB84C5967107110D35D514C7DAC97282D063C67CFD4E84987597EC79699C0E6F21BD4036121A32F7402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCHv4 0/2] lua: fix tarantool -e always enters interactive X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Leonid Vasiliev via Tarantool-patches Reply-To: Leonid Vasiliev Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thank you for the patchset. LGTM. On 3/11/21 3:05 PM, Artem Starshov wrote: > Issue: https://github.com/tarantool/tarantool/issues/5040 > Branch: https://github.com/tarantool/tarantool/tree/artemreyt/gh-5040-interactive-mode-bug > > Changes in v4: > * core: > - add wiki for setting error injections vi env: https://github.com/tarantool/tarantool/wiki/Error-injections; > - since now `panic()` is invoked in case of wrong value for errinj environment variable; > - some codestyle fixes; > * lua: > - add changelogs/unreleased/fix-tarantool-e-option.md; > - some codestyle fixes; > > Artem Starshov (2): > core: add setting error injections via env > lua: fix tarantool -e always enters interactive mode > > .../unreleased/fix-tarantool-e-option.md | 6 + > src/lib/core/errinj.c | 37 +++++ > src/lib/core/errinj.h | 6 + > src/lua/init.c | 27 +++- > src/main.cc | 3 + > ...5040-inter-mode-isatty-via-errinj.test.lua | 126 ++++++++++++++++++ > test/app-tap/suite.ini | 1 + > .../errinj_set_with_enviroment_vars.test.lua | 29 ++++ > ...errinj_set_with_enviroment_vars_script.lua | 34 +++++ > test/box-tap/suite.ini | 1 + > test/box/errinj.result | 1 + > 11 files changed, 267 insertions(+), 4 deletions(-) > create mode 100644 changelogs/unreleased/fix-tarantool-e-option.md > create mode 100755 test/app-tap/gh-5040-inter-mode-isatty-via-errinj.test.lua > create mode 100755 test/box-tap/errinj_set_with_enviroment_vars.test.lua > create mode 100644 test/box-tap/errinj_set_with_enviroment_vars_script.lua >