Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Artem Starshov <artemreyt@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
	Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCHv4 0/2] lua: fix tarantool -e always enters interactive
Date: Fri, 12 Mar 2021 16:40:24 +0000	[thread overview]
Message-ID: <20210312164024.kqqeubidfpboqsyu@tarantool.org> (raw)
In-Reply-To: <cover.1615463815.git.artemreyt@tarantool.org>

Hello,

On 11 мар 15:05, Artem Starshov via Tarantool-patches wrote:
> Issue: https://github.com/tarantool/tarantool/issues/5040
> Branch: https://github.com/tarantool/tarantool/tree/artemreyt/gh-5040-interactive-mode-bug
> 
> Changes in v4:
>   * core:
>     - add wiki for setting error injections vi env: https://github.com/tarantool/tarantool/wiki/Error-injections;
>     - since now `panic()` is invoked in case of wrong value for errinj environment variable;
>     - some codestyle fixes;
>   * lua:
>     - add changelogs/unreleased/fix-tarantool-e-option.md;
>     - some codestyle fixes;
> 
> Artem Starshov (2):
>   core: add setting error injections via env
>   lua: fix tarantool -e always enters interactive mode
> 
>  .../unreleased/fix-tarantool-e-option.md      |   6 +
>  src/lib/core/errinj.c                         |  37 +++++
>  src/lib/core/errinj.h                         |   6 +
>  src/lua/init.c                                |  27 +++-
>  src/main.cc                                   |   3 +
>  ...5040-inter-mode-isatty-via-errinj.test.lua | 126 ++++++++++++++++++
>  test/app-tap/suite.ini                        |   1 +
>  .../errinj_set_with_enviroment_vars.test.lua  |  29 ++++
>  ...errinj_set_with_enviroment_vars_script.lua |  34 +++++
>  test/box-tap/suite.ini                        |   1 +
>  test/box/errinj.result                        |   1 +
>  11 files changed, 267 insertions(+), 4 deletions(-)
>  create mode 100644 changelogs/unreleased/fix-tarantool-e-option.md
>  create mode 100755 test/app-tap/gh-5040-inter-mode-isatty-via-errinj.test.lua
>  create mode 100755 test/box-tap/errinj_set_with_enviroment_vars.test.lua
>  create mode 100644 test/box-tap/errinj_set_with_enviroment_vars_script.lua

I've checked your patchset into 1.10, 2.6, 2.7 and master.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2021-03-12 16:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11 12:05 Artem Starshov via Tarantool-patches
2021-03-11 12:05 ` [Tarantool-patches] [PATCHv4 1/2] core: add setting error injections via env Artem Starshov via Tarantool-patches
2021-03-11 12:05 ` [Tarantool-patches] [PATCHv4 2/2] lua: fix tarantool -e always enters interactive mode Artem Starshov via Tarantool-patches
2021-03-11 12:34 ` [Tarantool-patches] [PATCHv4 0/2] lua: fix tarantool -e always enters interactive Leonid Vasiliev via Tarantool-patches
2021-03-12 16:40 ` Kirill Yukhin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210312164024.kqqeubidfpboqsyu@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=artemreyt@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCHv4 0/2] lua: fix tarantool -e always enters interactive' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox