Tarantool development patches archive
 help / color / mirror / Atom feed
* [Tarantool-patches] [PATCH] test: enable all LuaJIT tests for M1
@ 2021-08-18 19:52 Igor Munkin via Tarantool-patches
  2021-08-19  5:29 ` Sergey Kaplun via Tarantool-patches
  2021-08-19  8:24 ` Igor Munkin via Tarantool-patches
  0 siblings, 2 replies; 6+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2021-08-18 19:52 UTC (permalink / raw)
  To: Sergey Kaplun, Vitaliia Ioffe; +Cc: tarantool-patches

This patch enables all tests in tarantool/luajit to be run in CI, since
all issues found with them are finally resolved.

Follows up #6098
Follows up tarantool/tarantool-qa#120

Signed-off-by: Igor Munkin <imun@tarantool.org>
---

Issue: https://github.com/tarantool/tarantool/issues/6098
Branch: https://github.com/tarantool/tarantool/tree/imun/gh-6098-fix-luajit-tests-suite-failures
CI: https://github.com/tarantool/tarantool/commit/67f92d2

 .travis.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.mk b/.travis.mk
index db5116b25..e1d7ea194 100644
--- a/.travis.mk
+++ b/.travis.mk
@@ -396,7 +396,7 @@ test_osx_no_deps: build_osx
 # FIXME: Temporary target with reduced number of tests.
 # Use test_osx_no_deps target, when all M1 issues are resolved.
 test_osx_arm64_no_deps: build_osx
-	make PUC-Rio-Lua-5.1-tests lua-Harness-tests tarantool-tests
+	make LuaJIT-test
 
 test_osx: deps_osx test_osx_no_deps
 
-- 
2.25.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Tarantool-patches] [PATCH] test: enable all LuaJIT tests for M1
  2021-08-18 19:52 [Tarantool-patches] [PATCH] test: enable all LuaJIT tests for M1 Igor Munkin via Tarantool-patches
@ 2021-08-19  5:29 ` Sergey Kaplun via Tarantool-patches
  2021-08-19  6:04   ` Igor Munkin via Tarantool-patches
  2021-08-19  8:24 ` Igor Munkin via Tarantool-patches
  1 sibling, 1 reply; 6+ messages in thread
From: Sergey Kaplun via Tarantool-patches @ 2021-08-19  5:29 UTC (permalink / raw)
  To: Igor Munkin; +Cc: tarantool-patches

Hi, Igor!

Thanks for the patch, LGTM!

P.S. Can we enable Tarantool tests too?

-- 
Best regards,
Sergey Kaplun

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Tarantool-patches] [PATCH] test: enable all LuaJIT tests for M1
  2021-08-19  5:29 ` Sergey Kaplun via Tarantool-patches
@ 2021-08-19  6:04   ` Igor Munkin via Tarantool-patches
  2021-08-19  6:35     ` Vitaliia Ioffe via Tarantool-patches
  0 siblings, 1 reply; 6+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2021-08-19  6:04 UTC (permalink / raw)
  To: Sergey Kaplun; +Cc: tarantool-patches

Sergey,

Thanks for your review!

On 19.08.21, Sergey Kaplun wrote:
> Hi, Igor!
> 
> Thanks for the patch, LGTM!

Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>

> 
> P.S. Can we enable Tarantool tests too?

Unfortunately, not today: there are still some issues open for M1.

> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Tarantool-patches] [PATCH] test: enable all LuaJIT tests for M1
  2021-08-19  6:35     ` Vitaliia Ioffe via Tarantool-patches
@ 2021-08-19  6:34       ` Igor Munkin via Tarantool-patches
  0 siblings, 0 replies; 6+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2021-08-19  6:34 UTC (permalink / raw)
  To: Vitaliia Ioffe; +Cc: tarantool-patches

Vitaliia,

Thanks for your review!

On 19.08.21, Vitaliia Ioffe wrote:
> 
> Hi team, 
>  
> QA LGTM

Added your tag:
| Reviewed-by: Vitaliia Ioffe <v.ioffe@tarantool.org>

>  
>  
> --
> Vitaliia Ioffe
>  

<snipped>

>  

-- 
Best regards,
IM

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Tarantool-patches]  [PATCH] test: enable all LuaJIT tests for M1
  2021-08-19  6:04   ` Igor Munkin via Tarantool-patches
@ 2021-08-19  6:35     ` Vitaliia Ioffe via Tarantool-patches
  2021-08-19  6:34       ` Igor Munkin via Tarantool-patches
  0 siblings, 1 reply; 6+ messages in thread
From: Vitaliia Ioffe via Tarantool-patches @ 2021-08-19  6:35 UTC (permalink / raw)
  To: Igor Munkin; +Cc: tarantool-patches

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]


Hi team, 
 
QA LGTM
 
 
--
Vitaliia Ioffe
 
  
>Четверг, 19 августа 2021, 9:29 +03:00 от Igor Munkin <imun@tarantool.org>:
> 
>Sergey,
>
>Thanks for your review!
>
>On 19.08.21, Sergey Kaplun wrote:
>> Hi, Igor!
>>
>> Thanks for the patch, LGTM!
>
>Added your tag:
>| Reviewed-by: Sergey Kaplun < skaplun@tarantool.org >
>
>>
>> P.S. Can we enable Tarantool tests too?
>
>Unfortunately, not today: there are still some issues open for M1.
>
>>
>> --
>> Best regards,
>> Sergey Kaplun
>
>--
>Best regards,
>IM
 

[-- Attachment #2: Type: text/html, Size: 1123 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Tarantool-patches] [PATCH] test: enable all LuaJIT tests for M1
  2021-08-18 19:52 [Tarantool-patches] [PATCH] test: enable all LuaJIT tests for M1 Igor Munkin via Tarantool-patches
  2021-08-19  5:29 ` Sergey Kaplun via Tarantool-patches
@ 2021-08-19  8:24 ` Igor Munkin via Tarantool-patches
  1 sibling, 0 replies; 6+ messages in thread
From: Igor Munkin via Tarantool-patches @ 2021-08-19  8:24 UTC (permalink / raw)
  To: Sergey Kaplun, Vitaliia Ioffe; +Cc: tarantool-patches

I've checked the patch into master.

On 18.08.21, Igor Munkin wrote:
> This patch enables all tests in tarantool/luajit to be run in CI, since
> all issues found with them are finally resolved.
> 
> Follows up #6098
> Follows up tarantool/tarantool-qa#120
> 
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
> 
> Issue: https://github.com/tarantool/tarantool/issues/6098
> Branch: https://github.com/tarantool/tarantool/tree/imun/gh-6098-fix-luajit-tests-suite-failures
> CI: https://github.com/tarantool/tarantool/commit/67f92d2
> 
>  .travis.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

<snipped>

> -- 
> 2.25.0
> 

-- 
Best regards,
IM

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-08-19  8:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-18 19:52 [Tarantool-patches] [PATCH] test: enable all LuaJIT tests for M1 Igor Munkin via Tarantool-patches
2021-08-19  5:29 ` Sergey Kaplun via Tarantool-patches
2021-08-19  6:04   ` Igor Munkin via Tarantool-patches
2021-08-19  6:35     ` Vitaliia Ioffe via Tarantool-patches
2021-08-19  6:34       ` Igor Munkin via Tarantool-patches
2021-08-19  8:24 ` Igor Munkin via Tarantool-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox