From: Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] replication: fix flaky gh-3055-election-promote test
Date: Thu, 12 Aug 2021 10:58:19 +0000 [thread overview]
Message-ID: <20210812105819.xjhakcpxhbh2uk2z@tarantool.org> (raw)
In-Reply-To: <20210809074206.57564-1-sergepetrenko@tarantool.org>
Hello,
On 09 авг 10:42, Serge Petrenko via Tarantool-patches wrote:
> Found the following error in our CI:
>
> [001] Test failed! Result content mismatch:
> [001] --- replication/gh-3055-election-promote.result Mon Aug 2 17:52:55 2021
> [001] +++ var/rejects/replication/gh-3055-election-promote.reject Mon Aug 9 10:29:34 2021
> [001] @@ -88,7 +88,7 @@
> [001] | ...
> [001] assert(not box.info.ro)
> [001] | ---
> [001] - | - true
> [001] + | - error: assertion failed!
> [001] | ...
> [001] assert(box.info.election.term > term)
> [001] | ---
> [001]
>
> The problem was the same as in recently fixed election_qsync.test
> (commit 096a0a7d5e2442656d228658f89f0c7066c60b16): PROMOTE is written to
> WAL asynchronously, and box.ctl.promote() returns earlier than this
> happens.
>
> Fix the issue by waiting for the instance to become writeable.
>
> Follow-up #6034
I've checked your patch into 2.7, 2.8 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2021-08-12 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 7:42 Serge Petrenko via Tarantool-patches
2021-08-09 7:45 ` Cyrill Gorcunov via Tarantool-patches
2021-08-09 9:53 ` Vitaliia Ioffe via Tarantool-patches
2021-08-12 10:58 ` Kirill Yukhin via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812105819.xjhakcpxhbh2uk2z@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] replication: fix flaky gh-3055-election-promote test' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox