From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E305D6EC40; Thu, 12 Aug 2021 13:58:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E305D6EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628765906; bh=qbiXRoue9aSNCBFINY+j0JTnEH/wPOOETK7Dc9HhSKs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GGN4sKvYwUFdTAh9mqYx18vaZvyQ0uFgpo1A31eFoi7CXuBz3cUh8FhvRJvpqisHl djddCKeCRr7WNijhWq9y1N33LDWuDLBV0RsryKqKx+JRnwAzxyRArYxkGEjzeo+Cnu sY00x6Nv6jDpwKm5hW4nZjRkq00nMi+O3vzib9Ys= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B03F76EC40 for ; Thu, 12 Aug 2021 13:58:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B03F76EC40 Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1mE8Pj-0006A1-K7; Thu, 12 Aug 2021 13:58:20 +0300 Date: Thu, 12 Aug 2021 10:58:19 +0000 To: Serge Petrenko Message-ID: <20210812105819.xjhakcpxhbh2uk2z@tarantool.org> References: <20210809074206.57564-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210809074206.57564-1-sergepetrenko@tarantool.org> User-Agent: NeoMutt/20170113 (1.7.2) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD9ECFD080E047A606F6525B29142351271182A05F538085040C353AE367267CFCEDD59E744E374FA7CD296DC31C58B23D7BF401B36C4046032 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73DDC6BBB7CD71318EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063720E5706DB08A2EAB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8841C6DCB554E9C062BFF8723BB073647117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735209ECD01F8117BC8BEA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCC79BBD503376DD703AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F79006375E1AF29033B429C0D81D268191BDAD3D698AB9A7B718F8C4D1B931868CE1C5781A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16B42539A7722CA490CB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5689BFFD5832161EB7DCB73BEA829C89EBC23B296A021B738D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753177526CD55AFC11410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3473457D764E1CDE77652EEE05F5B600087DD1F5902EBADF9EE7E1ED4AB64C24B6B24E1AEDA86A4ABD1D7E09C32AA3244C513204E0BFC338FB5A307518B78FED5EF94338140B71B8EE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojKW4rnL99YhI9rdObxPlzYA== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD203A2CBFE1BFF8565631FAD377C0AE7C13CC4C97E5A7182EFCA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] replication: fix flaky gh-3055-election-promote test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 09 авг 10:42, Serge Petrenko via Tarantool-patches wrote: > Found the following error in our CI: > > [001] Test failed! Result content mismatch: > [001] --- replication/gh-3055-election-promote.result Mon Aug 2 17:52:55 2021 > [001] +++ var/rejects/replication/gh-3055-election-promote.reject Mon Aug 9 10:29:34 2021 > [001] @@ -88,7 +88,7 @@ > [001] | ... > [001] assert(not box.info.ro) > [001] | --- > [001] - | - true > [001] + | - error: assertion failed! > [001] | ... > [001] assert(box.info.election.term > term) > [001] | --- > [001] > > The problem was the same as in recently fixed election_qsync.test > (commit 096a0a7d5e2442656d228658f89f0c7066c60b16): PROMOTE is written to > WAL asynchronously, and box.ctl.promote() returns earlier than this > happens. > > Fix the issue by waiting for the instance to become writeable. > > Follow-up #6034 I've checked your patch into 2.7, 2.8 and master. -- Regards, Kirill Yukhin