From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: v.shpilevoy@tarantool.org, gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH] replication: fix flaky gh-3055-election-promote test Date: Mon, 9 Aug 2021 10:42:05 +0300 [thread overview] Message-ID: <20210809074206.57564-1-sergepetrenko@tarantool.org> (raw) Found the following error in our CI: [001] Test failed! Result content mismatch: [001] --- replication/gh-3055-election-promote.result Mon Aug 2 17:52:55 2021 [001] +++ var/rejects/replication/gh-3055-election-promote.reject Mon Aug 9 10:29:34 2021 [001] @@ -88,7 +88,7 @@ [001] | ... [001] assert(not box.info.ro) [001] | --- [001] - | - true [001] + | - error: assertion failed! [001] | ... [001] assert(box.info.election.term > term) [001] | --- [001] The problem was the same as in recently fixed election_qsync.test (commit 096a0a7d5e2442656d228658f89f0c7066c60b16): PROMOTE is written to WAL asynchronously, and box.ctl.promote() returns earlier than this happens. Fix the issue by waiting for the instance to become writeable. Follow-up #6034 --- https://github.com/tarantool/tarantool/tree/sp/election-promote-fix test/replication/gh-3055-election-promote.result | 4 ++-- test/replication/gh-3055-election-promote.test.lua | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/replication/gh-3055-election-promote.result b/test/replication/gh-3055-election-promote.result index 6f5af13bc..c51ee8056 100644 --- a/test/replication/gh-3055-election-promote.result +++ b/test/replication/gh-3055-election-promote.result @@ -50,7 +50,7 @@ assert(box.info.election.state == 'leader') | --- | - true | ... -assert(not box.info.ro) +test_run:wait_cond(function() return not box.info.ro end) | --- | - true | ... @@ -86,7 +86,7 @@ assert(box.info.election.state == 'leader') | --- | - true | ... -assert(not box.info.ro) +test_run:wait_cond(function() return not box.info.ro end) | --- | - true | ... diff --git a/test/replication/gh-3055-election-promote.test.lua b/test/replication/gh-3055-election-promote.test.lua index cbc3ed206..84acc24b8 100644 --- a/test/replication/gh-3055-election-promote.test.lua +++ b/test/replication/gh-3055-election-promote.test.lua @@ -24,7 +24,7 @@ assert(box.info.election.state == 'follower') term = box.info.election.term box.ctl.promote() assert(box.info.election.state == 'leader') -assert(not box.info.ro) +test_run:wait_cond(function() return not box.info.ro end) assert(box.info.election.term > term) -- Test promote when there's a live leader. @@ -35,7 +35,7 @@ assert(box.info.ro) assert(box.info.election.leader ~= 0) box.ctl.promote() assert(box.info.election.state == 'leader') -assert(not box.info.ro) +test_run:wait_cond(function() return not box.info.ro end) assert(box.info.election.term > term) -- Cleanup. -- 2.30.1 (Apple Git-130)
next reply other threads:[~2021-08-09 7:42 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-09 7:42 Serge Petrenko via Tarantool-patches [this message] 2021-08-09 7:45 ` Cyrill Gorcunov via Tarantool-patches 2021-08-09 9:53 ` Vitaliia Ioffe via Tarantool-patches 2021-08-12 10:58 ` Kirill Yukhin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210809074206.57564-1-sergepetrenko@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=gorcunov@gmail.com \ --cc=sergepetrenko@tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] replication: fix flaky gh-3055-election-promote test' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox