Tarantool development patches archive
 help / color / mirror / Atom feed
From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Timur Safin <tsafin@tarantool.org>
Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 2/2] sql: always show value in type mismatch error
Date: Fri, 25 Jun 2021 13:46:19 +0300	[thread overview]
Message-ID: <20210625104619.GA97325@tarantool.org> (raw)
In-Reply-To: <114901d769ab$431961e0$c94c25a0$@tarantool.org>

Hi! Thank you for your suggestions. My answers below.

On Fri, Jun 25, 2021 at 01:17:10PM +0300, Timur Safin wrote:
> : From: Kirill Yukhin via Tarantool-patches
> : Subject: Re: [Tarantool-patches] [PATCH v1 2/2] sql: always show value in
> : type mismatch error
> : 
> : Hello,
> : 
> : On 24 Jun 13:30, Mergen Imeev via Tarantool-patches wrote:
> : > diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c
> : >  -- Check interaction of BOOLEAN and TEXT.
> : > @@ -5272,124 +5272,124 @@ SELECT a2, d, d OR a2 FROM t6, t9;
> : >  SELECT true > 'abc';
> : >   | ---
> : >   | - null
> : > - | - 'Type mismatch: can not convert text to boolean'
> : > + | - 'Type mismatch: can not convert abc to boolean'
> : 
> : Is it possible to quote string values (like you do for varbinary)?
Yes, it is possible. I will make a patch.

> : 
> : --
> : Regards, Kirill Yukhin
> 
> Yep, agree with Kirill here - it would be more 
> distinguishable if textual literals (or UUID)
> would be properly quoted. 
> 
> Also, I assume that reporting original type was useful
> as well. So, if possible, it would be ideally if both 
> values and their types would be reported, e.g.
> 
> > @@ -5272,124 +5272,124 @@ SELECT a2, d, d OR a2 FROM t6, t9;
> >  SELECT true > 'abc';
> >   | ---
> >   | - null
> > - | - 'Type mismatch: can not convert text to boolean'
> > + | - 'Type mismatch: can not convert text ("abc") to boolean'
> 
> 
> Best Regards,
> Timur
> 
Ok. However, since this patch-set is now too large for an already closed issue,
I will make a new issue. In this issue, I will describe what changes I plan to
make.

Also, Timur please do not remove tarantool-patches@dev.tarantool.org from your
answers.


      parent reply	other threads:[~2021-06-25 10:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 10:30 [Tarantool-patches] [PATCH v1 0/2] sql: fix description of " Mergen Imeev via Tarantool-patches
2021-06-24 10:30 ` [Tarantool-patches] [PATCH v1 1/2] sql: show varbinary in " Mergen Imeev via Tarantool-patches
2021-06-24 20:24   ` Vladislav Shpilevoy via Tarantool-patches
2021-06-24 10:30 ` [Tarantool-patches] [PATCH v1 2/2] sql: always show value " Mergen Imeev via Tarantool-patches
2021-06-25  7:27   ` Kirill Yukhin via Tarantool-patches
     [not found]     ` <114901d769ab$431961e0$c94c25a0$@tarantool.org>
2021-06-25 10:46       ` Mergen Imeev via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210625104619.GA97325@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=tsafin@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 2/2] sql: always show value in type mismatch error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox